* re: USB: Add EHCI support for MX27 and MX31 based boards
@ 2013-08-21 8:39 Dan Carpenter
2013-08-21 9:18 ` Daniel Mack
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-21 8:39 UTC (permalink / raw)
To: kernel-janitors
[ This warning is very old actually ]
Hello Daniel Mack,
This is a semi-automatic email about new static checker warnings.
The patch 7e8d5cd93fac: "USB: Add EHCI support for MX27 and MX31
based boards" from Oct 28, 2009, leads to the following Smatch
complaint:
drivers/usb/host/ehci-mxc.c:187 ehci_mxc_drv_remove()
error: we previously assumed 'pdata' could be null (see line 184)
drivers/usb/host/ehci-mxc.c
183
184 if (pdata && pdata->exit)
^^^^^
New check.
185 pdata->exit(pdev);
186
187 if (pdata->otg)
^^^^^^^^^^
New dereference.
188 usb_phy_shutdown(pdata->otg);
189
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: USB: Add EHCI support for MX27 and MX31 based boards
2013-08-21 8:39 USB: Add EHCI support for MX27 and MX31 based boards Dan Carpenter
@ 2013-08-21 9:18 ` Daniel Mack
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Mack @ 2013-08-21 9:18 UTC (permalink / raw)
To: kernel-janitors
On 21.08.2013 10:39, Dan Carpenter wrote:
> [ This warning is very old actually ]
>
> Hello Daniel Mack,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 7e8d5cd93fac: "USB: Add EHCI support for MX27 and MX31
> based boards" from Oct 28, 2009, leads to the following Smatch
> complaint:
Indeed, that's quite old. I just sent out a patch to fix this.
Thanks for spotting!
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-21 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 8:39 USB: Add EHCI support for MX27 and MX31 based boards Dan Carpenter
2013-08-21 9:18 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox