From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Clemens Ladisch <clemens@ladisch.de>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] ALSA: fireworks: remove some stray checks
Date: Wed, 28 May 2014 21:57:11 +0000 [thread overview]
Message-ID: <53865BB7.5020006@sakamocchi.jp> (raw)
In-Reply-To: <20140528164202.GB1824@mwanda>
(May 29 2014 01:42), Dan Carpenter wrote:
> We checked "err" earlier. These things seem to be left over code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index a354d26..8e856cc 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -89,8 +89,6 @@ get_hardware_info(struct snd_efw *efw)
> snprintf(version, sizeof(version), "%u.%u",
> (hwinfo->arm_version >> 24) & 0xff,
> (hwinfo->arm_version >> 16) & 0xff);
> - if (err < 0)
> - goto end;
> efw->firmware_version = hwinfo->arm_version;
>
> strcpy(efw->card->driver, "Fireworks");
> @@ -101,8 +99,6 @@ get_hardware_info(struct snd_efw *efw)
> hwinfo->vendor_name, hwinfo->model_name, version,
> hwinfo->guid_hi, hwinfo->guid_lo,
> dev_name(&efw->unit->device), 100 << fw_dev->max_speed);
> - if (err < 0)
> - goto end;
>
> if (hwinfo->flags & BIT(FLAG_RESP_ADDR_CHANGABLE))
> efw->resp_addr_changable = true;
next prev parent reply other threads:[~2014-05-28 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 16:42 [patch 1/2] ALSA: fireworks: remove some stray checks Dan Carpenter
2014-05-28 21:57 ` Takashi Sakamoto [this message]
2014-05-29 13:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53865BB7.5020006@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox