* [patch 1/2] ALSA: fireworks: remove some stray checks
@ 2014-05-28 16:42 Dan Carpenter
2014-05-28 21:57 ` Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-05-28 16:42 UTC (permalink / raw)
To: Clemens Ladisch
Cc: Jaroslav Kysela, Takashi Iwai, Takashi Sakamoto, alsa-devel,
kernel-janitors
We checked "err" earlier. These things seem to be left over code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
index a354d26..8e856cc 100644
--- a/sound/firewire/fireworks/fireworks.c
+++ b/sound/firewire/fireworks/fireworks.c
@@ -89,8 +89,6 @@ get_hardware_info(struct snd_efw *efw)
snprintf(version, sizeof(version), "%u.%u",
(hwinfo->arm_version >> 24) & 0xff,
(hwinfo->arm_version >> 16) & 0xff);
- if (err < 0)
- goto end;
efw->firmware_version = hwinfo->arm_version;
strcpy(efw->card->driver, "Fireworks");
@@ -101,8 +99,6 @@ get_hardware_info(struct snd_efw *efw)
hwinfo->vendor_name, hwinfo->model_name, version,
hwinfo->guid_hi, hwinfo->guid_lo,
dev_name(&efw->unit->device), 100 << fw_dev->max_speed);
- if (err < 0)
- goto end;
if (hwinfo->flags & BIT(FLAG_RESP_ADDR_CHANGABLE))
efw->resp_addr_changable = true;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch 1/2] ALSA: fireworks: remove some stray checks
2014-05-28 16:42 [patch 1/2] ALSA: fireworks: remove some stray checks Dan Carpenter
@ 2014-05-28 21:57 ` Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2014-05-28 21:57 UTC (permalink / raw)
To: Dan Carpenter, Clemens Ladisch; +Cc: Takashi Iwai, alsa-devel, kernel-janitors
(May 29 2014 01:42), Dan Carpenter wrote:
> We checked "err" earlier. These things seem to be left over code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index a354d26..8e856cc 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -89,8 +89,6 @@ get_hardware_info(struct snd_efw *efw)
> snprintf(version, sizeof(version), "%u.%u",
> (hwinfo->arm_version >> 24) & 0xff,
> (hwinfo->arm_version >> 16) & 0xff);
> - if (err < 0)
> - goto end;
> efw->firmware_version = hwinfo->arm_version;
>
> strcpy(efw->card->driver, "Fireworks");
> @@ -101,8 +99,6 @@ get_hardware_info(struct snd_efw *efw)
> hwinfo->vendor_name, hwinfo->model_name, version,
> hwinfo->guid_hi, hwinfo->guid_lo,
> dev_name(&efw->unit->device), 100 << fw_dev->max_speed);
> - if (err < 0)
> - goto end;
>
> if (hwinfo->flags & BIT(FLAG_RESP_ADDR_CHANGABLE))
> efw->resp_addr_changable = true;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/2] ALSA: fireworks: remove some stray checks
2014-05-28 16:42 [patch 1/2] ALSA: fireworks: remove some stray checks Dan Carpenter
2014-05-28 21:57 ` Takashi Sakamoto
@ 2014-05-29 13:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2014-05-29 13:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Clemens Ladisch, Jaroslav Kysela, Takashi Sakamoto, alsa-devel,
kernel-janitors
At Wed, 28 May 2014 19:42:02 +0300,
Dan Carpenter wrote:
>
> We checked "err" earlier. These things seem to be left over code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index a354d26..8e856cc 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -89,8 +89,6 @@ get_hardware_info(struct snd_efw *efw)
> snprintf(version, sizeof(version), "%u.%u",
> (hwinfo->arm_version >> 24) & 0xff,
> (hwinfo->arm_version >> 16) & 0xff);
> - if (err < 0)
> - goto end;
> efw->firmware_version = hwinfo->arm_version;
>
> strcpy(efw->card->driver, "Fireworks");
> @@ -101,8 +99,6 @@ get_hardware_info(struct snd_efw *efw)
> hwinfo->vendor_name, hwinfo->model_name, version,
> hwinfo->guid_hi, hwinfo->guid_lo,
> dev_name(&efw->unit->device), 100 << fw_dev->max_speed);
> - if (err < 0)
> - goto end;
>
> if (hwinfo->flags & BIT(FLAG_RESP_ADDR_CHANGABLE))
> efw->resp_addr_changable = true;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-29 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28 16:42 [patch 1/2] ALSA: fireworks: remove some stray checks Dan Carpenter
2014-05-28 21:57 ` Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox