From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mpt2sas: issue reset is not uninitialized
Date: Wed, 03 Dec 2014 14:14:08 +0000 [thread overview]
Message-ID: <547F1AB0.30705@bfs.de> (raw)
In-Reply-To: <20141203100941.GB29583@mwanda>
Am 03.12.2014 11:09, schrieb Dan Carpenter:
> The issue_reset variables were never set to zero. This bug was found
> with static analysis.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 58e4521..98bd546 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
> u16 smid;
> u32 ioc_state;
> unsigned long timeleft;
> - u8 issue_reset;
> + bool issue_reset = 0;
> int rc;
> void *request;
> u16 wait_state_count;
> @@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
> u16 smid;
> u32 ioc_state;
> unsigned long timeleft;
> - u8 issue_reset;
> + bool issue_reset = 0;
> int rc;
> void *request;
> u16 wait_state_count;
hi Dan,
just a minor question:
did you forget to mention that you also changed from u8 to bool or was this unintentional ?
re,
wh
next prev parent reply other threads:[~2014-12-03 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 10:09 [patch] mpt2sas: issue reset is not uninitialized Dan Carpenter
2014-12-03 10:36 ` Julia Lawall
2014-12-03 11:03 ` Dan Carpenter
2014-12-03 14:14 ` walter harms [this message]
2014-12-03 14:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F1AB0.30705@bfs.de \
--to=wharms@bfs.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox