From: ebiederm@xmission.com (Eric W. Biederman)
To: Bas Peters <baspeters93@gmail.com>
Cc: akpm@linux-foundation.org, oleg@redhat.com, adobriyan@gmail.com,
gorcunov@openvz.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs: proc: inode.c: remove unnecessary type cast
Date: Wed, 11 Feb 2015 14:02:40 +0000 [thread overview]
Message-ID: <878ug4k0lb.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1423655925-15853-1-git-send-email-baspeters93@gmail.com> (Bas Peters's message of "Wed, 11 Feb 2015 12:58:45 +0100")
Bas Peters <baspeters93@gmail.com> writes:
> Issue was detected using Coccinelle.
I believe Al Viro wrote that deliberately.
> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> fs/proc/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 8420a2f..e16ee87 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)
> struct proc_inode *ei;
> struct inode *inode;
>
> - ei = (struct proc_inode *)kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> ei->pid = NULL;
Eric
prev parent reply other threads:[~2015-02-11 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 11:58 [PATCH] fs: proc: inode.c: remove unnecessary type cast Bas Peters
2015-02-11 14:02 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ug4k0lb.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baspeters93@gmail.com \
--cc=gorcunov@openvz.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox