* [PATCH] fs: proc: inode.c: remove unnecessary type cast
@ 2015-02-11 11:58 Bas Peters
2015-02-11 14:02 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Bas Peters @ 2015-02-11 11:58 UTC (permalink / raw)
To: akpm
Cc: Bas Peters, oleg, adobriyan, gorcunov, ebiederm, viro,
linux-kernel, kernel-janitors
Issue was detected using Coccinelle.
Signed-off-by: Bas Peters <baspeters93@gmail.com>
---
fs/proc/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 8420a2f..e16ee87 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)
struct proc_inode *ei;
struct inode *inode;
- ei = (struct proc_inode *)kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
+ ei = kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
if (!ei)
return NULL;
ei->pid = NULL;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: proc: inode.c: remove unnecessary type cast
2015-02-11 11:58 [PATCH] fs: proc: inode.c: remove unnecessary type cast Bas Peters
@ 2015-02-11 14:02 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2015-02-11 14:02 UTC (permalink / raw)
To: Bas Peters
Cc: akpm, oleg, adobriyan, gorcunov, viro, linux-kernel,
kernel-janitors
Bas Peters <baspeters93@gmail.com> writes:
> Issue was detected using Coccinelle.
I believe Al Viro wrote that deliberately.
> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> fs/proc/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 8420a2f..e16ee87 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)
> struct proc_inode *ei;
> struct inode *inode;
>
> - ei = (struct proc_inode *)kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> ei->pid = NULL;
Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-11 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11 11:58 [PATCH] fs: proc: inode.c: remove unnecessary type cast Bas Peters
2015-02-11 14:02 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox