* [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_pro
@ 2017-09-08 20:14 SF Markus Elfring
2017-09-09 12:41 ` [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-09-08 20:14 UTC (permalink / raw)
To: linux-media, Hans Verkuil, Mauro Carvalho Chehab, Petr Cvek,
Robert Jarzmik, Sakari Ailus, Wei Yongjun
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 8 Sep 2017 22:05:14 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/pxa_camera.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
index edca993c2b1f..d2a4432a98ea 100644
--- a/drivers/media/platform/pxa_camera.c
+++ b/drivers/media/platform/pxa_camera.c
@@ -2362,10 +2362,8 @@ static int pxa_camera_probe(struct platform_device *pdev)
return -ENODEV;
pcdev = devm_kzalloc(&pdev->dev, sizeof(*pcdev), GFP_KERNEL);
- if (!pcdev) {
- dev_err(&pdev->dev, "Could not allocate pcdev\n");
+ if (!pcdev)
return -ENOMEM;
- }
pcdev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(pcdev->clk))
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera
2017-09-08 20:14 [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_pro SF Markus Elfring
@ 2017-09-09 12:41 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2017-09-09 12:41 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-media, Hans Verkuil, Mauro Carvalho Chehab, Petr Cvek,
Sakari Ailus, Wei Yongjun, LKML, kernel-janitors
SF Markus Elfring <elfring@users.sourceforge.net> writes:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 8 Sep 2017 22:05:14 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-09 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-08 20:14 [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_pro SF Markus Elfring
2017-09-09 12:41 ` [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox