* Re: [cocci] [PATCH v2 1/3] coccinelle: misc: secs_to_jiffies: Patch expressions too [not found] ` <20250203-converge-secs-to-jiffies-part-two-v2-1-d7058a01fd0e@linux.microsoft.com> @ 2025-02-04 7:56 ` Markus Elfring 2025-02-04 16:20 ` Easwar Hariharan 0 siblings, 1 reply; 3+ messages in thread From: Markus Elfring @ 2025-02-04 7:56 UTC (permalink / raw) To: Easwar Hariharan, cocci, Andrew Morton, Dongsheng Yang, Ilya Dryomov, Jens Axboe, Julia Lawall, Nicolas Palix, Ricardo Ribalda, Xiubo Li Cc: LKML, kernel-janitors, ceph-devel, linux-block > Teach the script to suggest conversions for timeout patterns where the > arguments to msecs_to_jiffies() are expressions as well. How do you imagine that the shown SmPL code fits ever to patch reviews? Examples: * https://lore.kernel.org/cocci/80cae791-663c-4589-b67e-d4d1049fcd98@web.de/ https://sympa.inria.fr/sympa/arc/cocci/2025-02/msg00002.html https://lkml.org/lkml/2025/2/3/151 * https://lore.kernel.org/cocci/e06cb7f5-7aa3-464c-a8a1-2c7b9b6a29eb@web.de/ https://sympa.inria.fr/sympa/arc/cocci/2025-01/msg00122.html https://lkml.org/lkml/2025/1/30/307 Regards, Markus ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [cocci] [PATCH v2 1/3] coccinelle: misc: secs_to_jiffies: Patch expressions too 2025-02-04 7:56 ` [cocci] [PATCH v2 1/3] coccinelle: misc: secs_to_jiffies: Patch expressions too Markus Elfring @ 2025-02-04 16:20 ` Easwar Hariharan 2025-02-04 20:24 ` [cocci] [v2 " Markus Elfring 0 siblings, 1 reply; 3+ messages in thread From: Easwar Hariharan @ 2025-02-04 16:20 UTC (permalink / raw) To: Markus Elfring Cc: cocci, Andrew Morton, Dongsheng Yang, Ilya Dryomov, Jens Axboe, Julia Lawall, Nicolas Palix, Ricardo Ribalda, Xiubo Li, eahariha, LKML, kernel-janitors, ceph-devel, linux-block On 2/3/2025 11:56 PM, Markus Elfring wrote: >> Teach the script to suggest conversions for timeout patterns where the >> arguments to msecs_to_jiffies() are expressions as well. > How do you imagine that the shown SmPL code fits ever to patch reviews? By the simple fact of accomplishing the same result despite differences in code style, as explicitly called out in the changelog. - Easwar (he/him) ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [cocci] [v2 1/3] coccinelle: misc: secs_to_jiffies: Patch expressions too 2025-02-04 16:20 ` Easwar Hariharan @ 2025-02-04 20:24 ` Markus Elfring 0 siblings, 0 replies; 3+ messages in thread From: Markus Elfring @ 2025-02-04 20:24 UTC (permalink / raw) To: Easwar Hariharan, cocci, Andrew Morton, Dongsheng Yang, Ilya Dryomov, Jens Axboe, Julia Lawall, Nicolas Palix, Ricardo Ribalda, Xiubo Li Cc: LKML, kernel-janitors, ceph-devel, linux-block >> How do you imagine that the shown SmPL code fits ever to patch reviews? > > By the simple fact of accomplishing the same result despite differences in > code style, as explicitly called out in the changelog. Do any other contributors care more for the mentioned software development concerns? How do you think about helping to improve affected implementation details? Regards, Markus ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-04 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com>
[not found] ` <20250203-converge-secs-to-jiffies-part-two-v2-1-d7058a01fd0e@linux.microsoft.com>
2025-02-04 7:56 ` [cocci] [PATCH v2 1/3] coccinelle: misc: secs_to_jiffies: Patch expressions too Markus Elfring
2025-02-04 16:20 ` Easwar Hariharan
2025-02-04 20:24 ` [cocci] [v2 " Markus Elfring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox