public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [git:media_stage/master] media: dvb-frontends/stv0367: remove redundant variable ADCClk_Hz
@ 2021-11-19 16:09 Mauro Carvalho Chehab
  0 siblings, 0 replies; only message in thread
From: Mauro Carvalho Chehab @ 2021-11-19 16:09 UTC (permalink / raw)
  To: linuxtv-commits; +Cc: Kieran Bingham, kernel-janitors, Colin Ian King

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: dvb-frontends/stv0367: remove redundant variable ADCClk_Hz
Author:  Colin Ian King <colin.king@canonical.com>
Date:    Thu Oct 14 16:32:53 2021 +0100

GIT_AUTHOR_NAME=Colin King
GIT_AUTHOR_EMAIL=colin.king@canonical.com

Variable ADCClk_Hz is being initialised with a variable that is never read
and then re-assigned immediately afterwards. Clean up the code by removing
it and just returning the return value from the call to stv0367cab_get_mclk

Addresses-Coverity: ("Unused value")

Link: https://lore.kernel.org/linux-media/20211014153253.63527-1-colin.king@canonical.com

Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/media/dvb-frontends/stv0367.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

---

diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c
index 6c2b05fae1c5..95e376f23506 100644
--- a/drivers/media/dvb-frontends/stv0367.c
+++ b/drivers/media/dvb-frontends/stv0367.c
@@ -1797,11 +1797,7 @@ static u32 stv0367cab_get_mclk(struct dvb_frontend *fe, u32 ExtClk_Hz)
 
 static u32 stv0367cab_get_adc_freq(struct dvb_frontend *fe, u32 ExtClk_Hz)
 {
-	u32 ADCClk_Hz = ExtClk_Hz;
-
-	ADCClk_Hz = stv0367cab_get_mclk(fe, ExtClk_Hz);
-
-	return ADCClk_Hz;
+	return stv0367cab_get_mclk(fe, ExtClk_Hz);
 }
 
 static enum stv0367cab_mod stv0367cab_SetQamSize(struct stv0367_state *state,

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-19 17:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-19 16:09 [git:media_stage/master] media: dvb-frontends/stv0367: remove redundant variable ADCClk_Hz Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox