From: Petr Mladek <pmladek@suse.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Jeremy Dean Clifton <deaner92@yahoo.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Huang Shijie <shijie@os.amperecomputing.com>,
Ingo Molnar <mingo@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Raul Rangel <rrangel@chromium.org>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yuntao Wang <ytcoode@gmail.com>
Subject: Re: init: Unnecessary braces around single line statement
Date: Tue, 28 Jan 2025 10:24:47 +0100 [thread overview]
Message-ID: <Z5iiX9clA62t8Llf@pathway.suse.cz> (raw)
In-Reply-To: <55498563-eb4d-4475-bf85-1543a59aed20@csgroup.eu>
On Tue 2025-01-28 09:59:08, Christophe Leroy wrote:
>
>
> Le 28/01/2025 à 09:45, Markus Elfring a écrit :
> > > So ask yourself whether such a change is really worth it.
> > Some change combinations can occasionally become more worthwhile,
> > can't they?
>
> Sure that change would be perfect as part of a series which modifies
> bootconfig_params(), but as a standalone change I can't see the benefit.
I agree here:
1. Cosmetic changes just complicate merging branches with really
useful changes. They are complicate backporting fixes to
stable kernels.
2. Cosmetic changes are material for bikeshedding. Some people might
prefer the original code because it is better readable for them...
3. The authors of cosmetic changes will not learn much by this.
Also it will also not help much to gain any reputation.
Best Regards,
Petr
next prev parent reply other threads:[~2025-01-28 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250125154139.7565-1-deaner92@yahoo.com>
2025-01-26 14:23 ` [PATCH] init: Unnecessary braces around single line statment Markus Elfring
[not found] ` <Z5iHRSUPEQoI2Rfl@vmi2410184.contaboserver.net>
2025-01-28 7:42 ` Markus Elfring
[not found] ` <5033d386-0765-486d-bf5a-68fe790ee455@csgroup.eu>
2025-01-28 8:45 ` init: Unnecessary braces around single line statement Markus Elfring
2025-01-28 8:59 ` Christophe Leroy
2025-01-28 9:24 ` Petr Mladek [this message]
2025-01-28 13:34 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5iiX9clA62t8Llf@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=deaner92@yahoo.com \
--cc=geert+renesas@glider.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rrangel@chromium.org \
--cc=shijie@os.amperecomputing.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox