* Re: [PATCH] init: Unnecessary braces around single line statment.
[not found] <20250125154139.7565-1-deaner92@yahoo.com>
@ 2025-01-26 14:23 ` Markus Elfring
[not found] ` <Z5iHRSUPEQoI2Rfl@vmi2410184.contaboserver.net>
0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2025-01-26 14:23 UTC (permalink / raw)
To: Jeremy Clifton, kernel-janitors
Cc: LKML, Andrew Morton, Christophe Leroy, Geert Uytterhoeven,
Huang Shijie, Ingo Molnar, Luis Chamberlain, Masami Hiramatsu,
Paul Menzel, Petr Mladek, Raul Rangel, Tejun Heo, Thomas Gleixner,
Yuntao Wang
> Warning found with checkpatch.pl script. Removed unnecessary braces.
1. An imperative wording can be more desirable for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94
2. Please avoid a typo in the summary phrase.
3. It is probably helpful to specify selected email addresses also in the message field “To”.
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: init: Unnecessary braces around single line statment.
[not found] ` <Z5iHRSUPEQoI2Rfl@vmi2410184.contaboserver.net>
@ 2025-01-28 7:42 ` Markus Elfring
[not found] ` <5033d386-0765-486d-bf5a-68fe790ee455@csgroup.eu>
1 sibling, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2025-01-28 7:42 UTC (permalink / raw)
To: Jeremy Dean Clifton, kernel-janitors
Cc: LKML, Andrew Morton, Christophe Leroy, Geert Uytterhoeven,
Huang Shijie, Ingo Molnar, Luis Chamberlain, Masami Hiramatsu,
Paul Menzel, Petr Mladek, Raul Rangel, Tejun Heo, Thomas Gleixner,
Yuntao Wang
>> 2. Please avoid a typo in the summary phrase.
>>
> I will need to resubmit another patch to the mailing list.
Yes, please.
> How do I close this one?
It will probably be noticed that you sent a subsequent patch version.
> Should I reference this in the new post with 'Fixes?'
Unlikely.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n310
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: init: Unnecessary braces around single line statement
[not found] ` <5033d386-0765-486d-bf5a-68fe790ee455@csgroup.eu>
@ 2025-01-28 8:45 ` Markus Elfring
2025-01-28 8:59 ` Christophe Leroy
0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2025-01-28 8:45 UTC (permalink / raw)
To: Christophe Leroy, Jeremy Dean Clifton, kernel-janitors
Cc: LKML, Andrew Morton, Geert Uytterhoeven, Huang Shijie,
Ingo Molnar, Luis Chamberlain, Masami Hiramatsu, Paul Menzel,
Petr Mladek, Raul Rangel, Tejun Heo, Thomas Gleixner, Yuntao Wang
> So ask yourself whether such a change is really worth it.
Some change combinations can occasionally become more worthwhile,
can't they?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: init: Unnecessary braces around single line statement
2025-01-28 8:45 ` init: Unnecessary braces around single line statement Markus Elfring
@ 2025-01-28 8:59 ` Christophe Leroy
2025-01-28 9:24 ` Petr Mladek
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2025-01-28 8:59 UTC (permalink / raw)
To: Markus Elfring, Jeremy Dean Clifton, kernel-janitors
Cc: LKML, Andrew Morton, Geert Uytterhoeven, Huang Shijie,
Ingo Molnar, Luis Chamberlain, Masami Hiramatsu, Paul Menzel,
Petr Mladek, Raul Rangel, Tejun Heo, Thomas Gleixner, Yuntao Wang
Le 28/01/2025 à 09:45, Markus Elfring a écrit :
>> So ask yourself whether such a change is really worth it.
> Some change combinations can occasionally become more worthwhile,
> can't they?
Sure that change would be perfect as part of a series which modifies
bootconfig_params(), but as a standalone change I can't see the benefit.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: init: Unnecessary braces around single line statement
2025-01-28 8:59 ` Christophe Leroy
@ 2025-01-28 9:24 ` Petr Mladek
2025-01-28 13:34 ` Markus Elfring
0 siblings, 1 reply; 6+ messages in thread
From: Petr Mladek @ 2025-01-28 9:24 UTC (permalink / raw)
To: Christophe Leroy
Cc: Markus Elfring, Jeremy Dean Clifton, kernel-janitors, LKML,
Andrew Morton, Geert Uytterhoeven, Huang Shijie, Ingo Molnar,
Luis Chamberlain, Masami Hiramatsu, Paul Menzel, Raul Rangel,
Tejun Heo, Thomas Gleixner, Yuntao Wang
On Tue 2025-01-28 09:59:08, Christophe Leroy wrote:
>
>
> Le 28/01/2025 à 09:45, Markus Elfring a écrit :
> > > So ask yourself whether such a change is really worth it.
> > Some change combinations can occasionally become more worthwhile,
> > can't they?
>
> Sure that change would be perfect as part of a series which modifies
> bootconfig_params(), but as a standalone change I can't see the benefit.
I agree here:
1. Cosmetic changes just complicate merging branches with really
useful changes. They are complicate backporting fixes to
stable kernels.
2. Cosmetic changes are material for bikeshedding. Some people might
prefer the original code because it is better readable for them...
3. The authors of cosmetic changes will not learn much by this.
Also it will also not help much to gain any reputation.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: init: Unnecessary braces around single line statement
2025-01-28 9:24 ` Petr Mladek
@ 2025-01-28 13:34 ` Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2025-01-28 13:34 UTC (permalink / raw)
To: Petr Mladek, Christophe Leroy
Cc: Jeremy Dean Clifton, kernel-janitors, LKML, Andrew Morton,
Geert Uytterhoeven, Huang Shijie, Ingo Molnar, Luis Chamberlain,
Masami Hiramatsu, Paul Menzel, Raul Rangel, Tejun Heo,
Thomas Gleixner, Yuntao Wang
…
> 3. The authors of cosmetic changes will not learn much by this.…
Would any contributors wonder how many efforts may be invested in coding style improvements
for selected software components?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-28 13:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250125154139.7565-1-deaner92@yahoo.com>
2025-01-26 14:23 ` [PATCH] init: Unnecessary braces around single line statment Markus Elfring
[not found] ` <Z5iHRSUPEQoI2Rfl@vmi2410184.contaboserver.net>
2025-01-28 7:42 ` Markus Elfring
[not found] ` <5033d386-0765-486d-bf5a-68fe790ee455@csgroup.eu>
2025-01-28 8:45 ` init: Unnecessary braces around single line statement Markus Elfring
2025-01-28 8:59 ` Christophe Leroy
2025-01-28 9:24 ` Petr Mladek
2025-01-28 13:34 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox