* [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup()
@ 2024-01-10 18:07 Christophe JAILLET
2024-01-11 11:51 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-01-10 18:07 UTC (permalink / raw)
To: vkoul, jiaheng.fan, peng.ma, wen.he_1
Cc: dmaengine, linux-kernel, kernel-janitors, Christophe JAILLET
When calling spi_register_board_info(), we should pass the number of
elements in 'db1200_spi_devs', not 'db1200_i2c_devs'.
Fixes: 63323ec54a7e ("MIPS: Alchemy: Extended DB1200 board support.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
arch/mips/alchemy/devboards/db1200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
index f521874ebb07..67f067706af2 100644
--- a/arch/mips/alchemy/devboards/db1200.c
+++ b/arch/mips/alchemy/devboards/db1200.c
@@ -847,7 +847,7 @@ int __init db1200_dev_setup(void)
i2c_register_board_info(0, db1200_i2c_devs,
ARRAY_SIZE(db1200_i2c_devs));
spi_register_board_info(db1200_spi_devs,
- ARRAY_SIZE(db1200_i2c_devs));
+ ARRAY_SIZE(db1200_spi_devs));
/* SWITCHES: S6.8 I2C/SPI selector (OFF=I2C ON=SPI)
* S6.7 AC97/I2S selector (OFF=AC97 ON=I2S)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup()
2024-01-10 18:07 [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup() Christophe JAILLET
@ 2024-01-11 11:51 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2024-01-11 11:51 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vkoul, jiaheng.fan, peng.ma, wen.he_1, dmaengine, linux-kernel,
kernel-janitors
On Wed, Jan 10, 2024 at 07:07:36PM +0100, Christophe JAILLET wrote:
> When calling spi_register_board_info(), we should pass the number of
> elements in 'db1200_spi_devs', not 'db1200_i2c_devs'.
>
> Fixes: 63323ec54a7e ("MIPS: Alchemy: Extended DB1200 board support.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> arch/mips/alchemy/devboards/db1200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
> index f521874ebb07..67f067706af2 100644
> --- a/arch/mips/alchemy/devboards/db1200.c
> +++ b/arch/mips/alchemy/devboards/db1200.c
> @@ -847,7 +847,7 @@ int __init db1200_dev_setup(void)
> i2c_register_board_info(0, db1200_i2c_devs,
> ARRAY_SIZE(db1200_i2c_devs));
> spi_register_board_info(db1200_spi_devs,
> - ARRAY_SIZE(db1200_i2c_devs));
> + ARRAY_SIZE(db1200_spi_devs));
>
> /* SWITCHES: S6.8 I2C/SPI selector (OFF=I2C ON=SPI)
> * S6.7 AC97/I2S selector (OFF=AC97 ON=I2S)
> --
> 2.34.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-11 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 18:07 [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup() Christophe JAILLET
2024-01-11 11:51 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox