* [PATCH next] drm/amd/ras: Fix a NULL vs IS_ERR() bug in ras_process_init()
@ 2025-10-22 11:04 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2025-10-22 11:04 UTC (permalink / raw)
To: YiPeng Chai
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Hawking Zhang, Tao Zhou, amd-gfx, dri-devel, linux-kernel,
kernel-janitors
The kthread_run() function never returns NULL, it returns error pointers.
Fix the error checking to match.
Fixes: ea61341b9014 ("drm/amd/ras: Add thread to handle ras events")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/amd/ras/rascore/ras_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/ras/rascore/ras_process.c b/drivers/gpu/drm/amd/ras/rascore/ras_process.c
index 02f0657f78a3..1d2f136fbe2b 100644
--- a/drivers/gpu/drm/amd/ras/rascore/ras_process.c
+++ b/drivers/gpu/drm/amd/ras/rascore/ras_process.c
@@ -241,9 +241,9 @@ int ras_process_init(struct ras_core_context *ras_core)
ras_proc->ras_process_thread = kthread_run(ras_process_thread,
(void *)ras_core, "ras_process_thread");
- if (!ras_proc->ras_process_thread) {
+ if (IS_ERR(ras_proc->ras_process_thread)) {
RAS_DEV_ERR(ras_core->dev, "Failed to create ras_process_thread.\n");
- ret = -ENOMEM;
+ ret = PTR_ERR(ras_proc->ras_process_thread);
goto err;
}
--
2.51.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-22 11:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 11:04 [PATCH next] drm/amd/ras: Fix a NULL vs IS_ERR() bug in ras_process_init() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox