* [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result()
@ 2025-12-03 11:14 Dan Carpenter
2025-12-03 17:57 ` Rolf Reintjes
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2025-12-03 11:14 UTC (permalink / raw)
To: qgeniecore; +Cc: Johannes Berg, linux-wireless, linux-kernel, kernel-janitors
The QGenie AI code review tool says we should store the capped length to
wdev->u.client.ssid_len. The AI is correct.
Fixes: 62b635dcd69c ("wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
net/wireless/sme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 3a028ff287fb..4e629ca305bc 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -910,7 +910,7 @@ void __cfg80211_connect_result(struct net_device *dev,
ssid_len = min(ssid->datalen, IEEE80211_MAX_SSID_LEN);
memcpy(wdev->u.client.ssid, ssid->data, ssid_len);
- wdev->u.client.ssid_len = ssid->datalen;
+ wdev->u.client.ssid_len = ssid_len;
break;
}
rcu_read_unlock();
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result()
2025-12-03 11:14 [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result() Dan Carpenter
@ 2025-12-03 17:57 ` Rolf Reintjes
2025-12-04 8:00 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Rolf Reintjes @ 2025-12-03 17:57 UTC (permalink / raw)
To: Dan Carpenter, qgeniecore
Cc: Johannes Berg, linux-wireless, linux-kernel, kernel-janitors
Hello Dan,
Am 03.12.2025 um 12:14 schrieb Dan Carpenter:
> The QGenie AI code review tool
Could you tell us more about this tool? Is there a web page of this
tool, how do you use this tool?
I found https://qgenie.ai/ but this is not a code review tool.
Rolf
> says we should store the capped length to
> wdev->u.client.ssid_len. The AI is correct.
>
> Fixes: 62b635dcd69c ("wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> net/wireless/sme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 3a028ff287fb..4e629ca305bc 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -910,7 +910,7 @@ void __cfg80211_connect_result(struct net_device *dev,
>
> ssid_len = min(ssid->datalen, IEEE80211_MAX_SSID_LEN);
> memcpy(wdev->u.client.ssid, ssid->data, ssid_len);
> - wdev->u.client.ssid_len = ssid->datalen;
> + wdev->u.client.ssid_len = ssid_len;
> break;
> }
> rcu_read_unlock();
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result()
2025-12-03 17:57 ` Rolf Reintjes
@ 2025-12-04 8:00 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-12-04 8:00 UTC (permalink / raw)
To: Rolf Reintjes
Cc: qgeniecore, Johannes Berg, linux-wireless, linux-kernel,
kernel-janitors
On Wed, Dec 03, 2025 at 06:57:42PM +0100, Rolf Reintjes wrote:
> Hello Dan,
>
> Am 03.12.2025 um 12:14 schrieb Dan Carpenter:
> > The QGenie AI code review tool
>
> Could you tell us more about this tool? Is there a web page of this tool,
> how do you use this tool?
>
> I found https://qgenie.ai/ but this is not a code review tool.
>
No idea. To be honest, I think it CC'd me by mistake.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-04 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-03 11:14 [PATCH] wifi: cfg80211: sme: store capped length in __cfg80211_connect_result() Dan Carpenter
2025-12-03 17:57 ` Rolf Reintjes
2025-12-04 8:00 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox