* Re: [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() [not found] <20260116074836.1199951-1-zilin@seu.edu.cn> @ 2026-01-16 11:04 ` Markus Elfring 2026-01-16 11:41 ` Zong-Zhe Yang 0 siblings, 1 reply; 4+ messages in thread From: Markus Elfring @ 2026-01-16 11:04 UTC (permalink / raw) To: Zilin Guan, linux-wireless, Ping-Ke Shih Cc: LKML, kernel-janitors, Jianhao Xu, Zong-Zhe Yang … > Fix this by freeing the temporary buffer bufp in the error path. … How do you think about to use an attribute like “__free(vfree)”? https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/net/wireless/realtek/rtw89/debug.c#L815-L858 Regards, Markus ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() 2026-01-16 11:04 ` [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() Markus Elfring @ 2026-01-16 11:41 ` Zong-Zhe Yang 2026-01-16 12:38 ` Markus Elfring 0 siblings, 1 reply; 4+ messages in thread From: Zong-Zhe Yang @ 2026-01-16 11:41 UTC (permalink / raw) To: Markus Elfring, Zilin Guan, linux-wireless@vger.kernel.org, Ping-Ke Shih Cc: LKML, kernel-janitors@vger.kernel.org, Jianhao Xu Markus Elfring <Markus.Elfring@web.de> wrote: > > … > > Fix this by freeing the temporary buffer bufp in the error path. > … > > How do you think about to use an attribute like “__free(vfree)”? > https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/net/wireless/realtek/rtw89/debug.c# > L815-L858 > Using __free(XXX) is fine to me. But, I don't seem to see DEFINE_FREE(vfree, ...) yet. So perhaps, need to use __free(kvfree). ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() 2026-01-16 11:41 ` Zong-Zhe Yang @ 2026-01-16 12:38 ` Markus Elfring 2026-01-16 13:48 ` Johannes Berg 0 siblings, 1 reply; 4+ messages in thread From: Markus Elfring @ 2026-01-16 12:38 UTC (permalink / raw) To: Zong-Zhe Yang, Zilin Guan, Ping-Ke Shih, linux-wireless, kernel-janitors Cc: LKML, Jianhao Xu > But, I don't seem to see DEFINE_FREE(vfree, ...) yet. … Would you dare to support the addition of such a macro call anyhow? https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/cleanup.h#L157-L161 Regards, Markus ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() 2026-01-16 12:38 ` Markus Elfring @ 2026-01-16 13:48 ` Johannes Berg 0 siblings, 0 replies; 4+ messages in thread From: Johannes Berg @ 2026-01-16 13:48 UTC (permalink / raw) To: Markus Elfring, Zong-Zhe Yang, Zilin Guan, Ping-Ke Shih, linux-wireless, kernel-janitors Cc: LKML, Jianhao Xu For the record, everyone, please just ignore Markus. I've told him numerous times to just leave us alone. johannes ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-16 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260116074836.1199951-1-zilin@seu.edu.cn>
2026-01-16 11:04 ` [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() Markus Elfring
2026-01-16 11:41 ` Zong-Zhe Yang
2026-01-16 12:38 ` Markus Elfring
2026-01-16 13:48 ` Johannes Berg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox