public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
	error27@gmail.com, Sunil Goutham <sgoutham@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	hariprasad <hkelam@marvell.com>,
	Bharat Bhushan <bbhushan2@marvell.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create()
Date: Mon, 16 Dec 2024 14:35:50 +0530	[thread overview]
Message-ID: <b97b401b-e318-412b-8344-a856c6e10eca@oracle.com> (raw)
In-Reply-To: <74d65f76-5e3a-44b6-b857-42b6c8cf7789@intel.com>

Hi,

On 16/12/24 13:39, Przemek Kitszel wrote:
> On 12/16/24 08:05, Harshit Mogalapalli wrote:
>> When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
>> incomplete iteration before going to "exit:" label.
>>
>> Fixes: 3937b7308d4f ("octeontx2-pf: Create representor netdev")
> 

Thanks for the review.
> I would say that you are fixing:
> Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
> 
Oh right, thank you for catching that. Will fix in V2.
> this is also a -net material

So while sending a V2 I will include [PATCH net-next], that sounds good ?

Thanks,
Harshit

  reply	other threads:[~2024-12-16  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16  7:05 [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create() Harshit Mogalapalli
2024-12-16  7:05 ` [PATCH next 2/2] octeontx2-pf: fix error handling of devlink port " Harshit Mogalapalli
2024-12-16  8:13   ` Przemek Kitszel
2024-12-16  8:09 ` [PATCH next 1/2] octeontx2-pf: fix netdev memory leak " Przemek Kitszel
2024-12-16  9:05   ` Harshit Mogalapalli [this message]
2024-12-16  9:15     ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b97b401b-e318-412b-8344-a856c6e10eca@oracle.com \
    --to=harshit.m.mogalapalli@oracle.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bbhushan2@marvell.com \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=error27@gmail.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=horms@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox