From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: <dan.carpenter@linaro.org>, <kernel-janitors@vger.kernel.org>,
<error27@gmail.com>, Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next 2/2] octeontx2-pf: fix error handling of devlink port in rvu_rep_create()
Date: Mon, 16 Dec 2024 09:13:16 +0100 [thread overview]
Message-ID: <d045f461-c60a-4653-9a89-81eafe2b12f8@intel.com> (raw)
In-Reply-To: <20241216070516.4036749-2-harshit.m.mogalapalli@oracle.com>
On 12/16/24 08:05, Harshit Mogalapalli wrote:
> Unregister the devlink port when register_netdev() fails.
>
> Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
same comment that this is better applied to -net, otherwise fine for me:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> ---
> This is from static analysis, only compile tested.
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> index 9e3fcbae5dee..04e08e06f30f 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> @@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
> if (err) {
> NL_SET_ERR_MSG_MOD(extack,
> "PFVF representor registration failed");
> + rvu_rep_devlink_port_unregister(rep);
> free_netdev(ndev);
> goto exit;
> }
next prev parent reply other threads:[~2024-12-16 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 7:05 [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create() Harshit Mogalapalli
2024-12-16 7:05 ` [PATCH next 2/2] octeontx2-pf: fix error handling of devlink port " Harshit Mogalapalli
2024-12-16 8:13 ` Przemek Kitszel [this message]
2024-12-16 8:09 ` [PATCH next 1/2] octeontx2-pf: fix netdev memory leak " Przemek Kitszel
2024-12-16 9:05 ` Harshit Mogalapalli
2024-12-16 9:15 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d045f461-c60a-4653-9a89-81eafe2b12f8@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=gakula@marvell.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox