* [patch] ALSA: hda - unlock on error in azx_interrupt()
@ 2012-05-18 7:36 Dan Carpenter
2012-05-18 13:47 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-05-18 7:36 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, kernel-janitors, David Henningsson
There is an spin_unlock() missing on this error path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This was added recently in a82d51ed2 "ALSA: hda - Support
VGA-switcheroo". I don't have the hardware so I haven't tested it.
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index bbf953f..2b6392b 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1268,8 +1268,10 @@ static irqreturn_t azx_interrupt(int irq, void *dev_id)
spin_lock(&chip->reg_lock);
- if (chip->disabled)
+ if (chip->disabled) {
+ spin_unlock(&chip->reg_lock);
return IRQ_NONE;
+ }
status = azx_readl(chip, INTSTS);
if (status = 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ALSA: hda - unlock on error in azx_interrupt()
2012-05-18 7:36 [patch] ALSA: hda - unlock on error in azx_interrupt() Dan Carpenter
@ 2012-05-18 13:47 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-05-18 13:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors, David Henningsson
At Fri, 18 May 2012 10:36:11 +0300,
Dan Carpenter wrote:
>
> There is an spin_unlock() missing on this error path.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This was added recently in a82d51ed2 "ALSA: hda - Support
> VGA-switcheroo". I don't have the hardware so I haven't tested it.
Good catch. Applied now.
Thanks.
Takashi
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index bbf953f..2b6392b 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1268,8 +1268,10 @@ static irqreturn_t azx_interrupt(int irq, void *dev_id)
>
> spin_lock(&chip->reg_lock);
>
> - if (chip->disabled)
> + if (chip->disabled) {
> + spin_unlock(&chip->reg_lock);
> return IRQ_NONE;
> + }
>
> status = azx_readl(chip, INTSTS);
> if (status = 0) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-18 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-18 7:36 [patch] ALSA: hda - unlock on error in azx_interrupt() Dan Carpenter
2012-05-18 13:47 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox