public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Alexander Tsoy <alexander@tsoy.me>
Subject: Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed
Date: Fri, 15 Jan 2021 15:52:15 +0000	[thread overview]
Message-ID: <s5hsg72kxjk.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210115154151.75022-1-colin.king@canonical.com>

On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This doesn't look applicable to the latest tree.
Could you check again?


thanks,

Takashi

> ---
>  sound/usb/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
>  {
>  	const struct audioformat *fp;
>  	unsigned int pt, ptmin;
> -	int param_period_time_if_needed = -1;
> +	int param_period_time_if_needed;
>  	int err;
>  
>  	runtime->hw.formats = subs->formats;
> -- 
> 2.29.2
> 

      reply	other threads:[~2021-01-15 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 15:41 [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed Colin King
2021-01-15 15:52 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsg72kxjk.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox