From: Pratyush Anand <panand@redhat.com>
To: "Hatayama, Daisuke" <d.hatayama@jp.fujitsu.com>
Cc: "'ats-kumagai@wm.jp.nec.com'" <ats-kumagai@wm.jp.nec.com>,
"'kexec@lists.infradead.org'" <kexec@lists.infradead.org>,
"'bhe@redhat.com'" <bhe@redhat.com>
Subject: Re: [PATCH 2/2] Revert "[PATCH V2 1/4] x86_64: Calculate page_offset from pt_load"
Date: Wed, 24 May 2017 11:51:10 +0530 [thread overview]
Message-ID: <07bb2312-6a8a-b7dd-451e-1ae4a0d726aa@redhat.com> (raw)
In-Reply-To: <7e95a840-2982-90bd-69fc-fe6f55caa0a0@redhat.com>
On Wednesday 24 May 2017 11:13 AM, Pratyush Anand wrote:
> Hi Hatayama,
>
>
> On Wednesday 24 May 2017 07:39 AM, Hatayama, Daisuke wrote:
>> How about this?
>> - return immediately in case of kaslr because there's no need to refer to
>> PT_LOAD entries,
>> - refer to PT_LOAD entries only if they exist, and
>> - finally try to get page offset according to kernel versions.
>
> It looks fine to me.
> So if you agree then I can send next revision with your "Suggested-by" tag.
>
> https://github.com/pratyushanand/makedumpfile/commit/16655ce1f4c2da8d4066072db2a03c84bf2553fe
return TRUEin case of KASLR success was missing in above. Fixed that.
https://github.com/pratyushanand/makedumpfile/commit/e13807fc6391bf71e7822d39cdb084d3bf481818
~Pratyush
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-05-24 6:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 2:54 [PATCH 2/2] Revert "[PATCH V2 1/4] x86_64: Calculate page_offset from pt_load" Hatayama, Daisuke
2017-05-23 3:23 ` Pratyush Anand
2017-05-23 4:12 ` Pratyush Anand
2017-05-23 7:25 ` Hatayama, Daisuke
2017-05-23 8:35 ` Pratyush Anand
2017-05-24 2:09 ` Hatayama, Daisuke
2017-05-24 5:43 ` Pratyush Anand
2017-05-24 6:21 ` Pratyush Anand [this message]
2017-05-25 1:11 ` Hatayama, Daisuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07bb2312-6a8a-b7dd-451e-1ae4a0d726aa@redhat.com \
--to=panand@redhat.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=bhe@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox