* [PATCH] kexec-tools: Fix unused return value warning for fread
@ 2010-03-19 13:55 Ameya Palande
2010-03-24 11:31 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Ameya Palande @ 2010-03-19 13:55 UTC (permalink / raw)
To: kexec; +Cc: horms
From: Ameya Palande <ameya.palande@nokia.com>
Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
---
kexec/arch/arm/kexec-zImage-arm.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c
index 3bb49a7..72fcdd8 100644
--- a/kexec/arch/arm/kexec-zImage-arm.c
+++ b/kexec/arch/arm/kexec-zImage-arm.c
@@ -110,7 +110,11 @@ struct tag * atag_read_tags(void)
return NULL;
}
- fread(buf, sizeof(buf[1]), BOOT_PARAMS_SIZE, fp);
+ if (!fread(buf, sizeof(buf[1]), BOOT_PARAMS_SIZE, fp)) {
+ fclose(fp);
+ return NULL;
+ }
+
if (ferror(fp)) {
fprintf(stderr, "Cannot read %s: %s\n",
fn, strerror(errno));
--
1.6.3.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kexec-tools: Fix unused return value warning for fread
2010-03-19 13:55 [PATCH] kexec-tools: Fix unused return value warning for fread Ameya Palande
@ 2010-03-24 11:31 ` Simon Horman
2010-03-25 11:23 ` Ameya Palande
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2010-03-24 11:31 UTC (permalink / raw)
To: Ameya Palande; +Cc: kexec
On Fri, Mar 19, 2010 at 03:55:04PM +0200, Ameya Palande wrote:
> From: Ameya Palande <ameya.palande@nokia.com>
>
> Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
Thanks, applied.
BTW, which gcc and CFLAGS were you using to see that warning?
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kexec-tools: Fix unused return value warning for fread
2010-03-24 11:31 ` Simon Horman
@ 2010-03-25 11:23 ` Ameya Palande
2010-03-25 22:54 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Ameya Palande @ 2010-03-25 11:23 UTC (permalink / raw)
To: ext Simon Horman; +Cc: kexec@lists.infradead.org
On Wed, 2010-03-24 at 12:31 +0100, ext Simon Horman wrote:
> On Fri, Mar 19, 2010 at 03:55:04PM +0200, Ameya Palande wrote:
> > From: Ameya Palande <ameya.palande@nokia.com>
> >
> > Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
>
> Thanks, applied.
>
> BTW, which gcc and CFLAGS were you using to see that warning?
>
I guess -Werror and gcc > 4 (I don't know exact version since I was
compiling it for arm on a build server).
Cheers,
Ameya.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kexec-tools: Fix unused return value warning for fread
2010-03-25 11:23 ` Ameya Palande
@ 2010-03-25 22:54 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2010-03-25 22:54 UTC (permalink / raw)
To: Ameya Palande; +Cc: kexec@lists.infradead.org
On Thu, Mar 25, 2010 at 01:23:53PM +0200, Ameya Palande wrote:
> On Wed, 2010-03-24 at 12:31 +0100, ext Simon Horman wrote:
> > On Fri, Mar 19, 2010 at 03:55:04PM +0200, Ameya Palande wrote:
> > > From: Ameya Palande <ameya.palande@nokia.com>
> > >
> > > Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
> >
> > Thanks, applied.
> >
> > BTW, which gcc and CFLAGS were you using to see that warning?
> >
>
> I guess -Werror and gcc > 4 (I don't know exact version since I was
> compiling it for arm on a build server).
Thanks. Though I don't seem to see them here with a similar (though non-arm)
setup.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-25 22:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-19 13:55 [PATCH] kexec-tools: Fix unused return value warning for fread Ameya Palande
2010-03-24 11:31 ` Simon Horman
2010-03-25 11:23 ` Ameya Palande
2010-03-25 22:54 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox