From: Daniel Kiper <daniel.kiper@oracle.com>
To: andrew.cooper3@citrix.com, kumagai-atsushi@mxc.nes.nec.co.jp,
kexec@lists.infradead.org, xen-devel@lists.xensource.com
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH v2 4/7] xen: Enforce page size only when xen-syms file is used
Date: Tue, 16 Jul 2013 14:32:06 +0200 [thread overview]
Message-ID: <1373977929-4253-5-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1373977929-4253-1-git-send-email-daniel.kiper@oracle.com>
Enforce page size only when xen-syms file is used.
Otherwise its size could be read from VMCOREINFO
file or /proc/vmcore file.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
makedumpfile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/makedumpfile.c b/makedumpfile.c
index b42565c..b4abbe5 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -7324,8 +7324,6 @@ initial_xen(void)
#endif
if (!init_xen_crash_info())
return FALSE;
- if (!fallback_to_current_page_size())
- return FALSE;
/*
* Get the debug information for analysis from the vmcoreinfo file
*/
@@ -7340,6 +7338,8 @@ initial_xen(void)
set_dwarf_debuginfo("xen-syms", NULL,
info->name_xen_syms, info->fd_xen_syms);
+ if (!fallback_to_current_page_size())
+ return FALSE;
if (!get_symbol_info_xen())
return FALSE;
if (!get_structure_info_xen())
--
1.7.10.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-07-16 12:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 12:32 [PATCH v2 0/7] makedumpfile: Xen fixes and minor cleanups Daniel Kiper
2013-07-16 12:32 ` [PATCH v2 1/7] xen: Improve calculation of beginning of virtual address space Daniel Kiper
2013-07-18 8:03 ` Atsushi Kumagai
2013-07-16 12:32 ` [PATCH v2 2/7] elf: Properly check buf size in get_pt_note_info() Daniel Kiper
2013-07-18 8:03 ` Atsushi Kumagai
2013-07-16 12:32 ` [PATCH v2 3/7] xen: Take into account new frame table address since Xen 4.3 Daniel Kiper
2013-07-18 8:03 ` Atsushi Kumagai
2013-07-16 12:32 ` Daniel Kiper [this message]
2013-07-19 9:20 ` [PATCH v2 4/7] xen: Enforce page size only when xen-syms file is used Atsushi Kumagai
2013-07-19 13:44 ` Daniel Kiper
2013-07-22 7:35 ` Atsushi Kumagai
2013-07-22 21:23 ` Daniel Kiper
2013-07-16 12:32 ` [PATCH v2 5/7] Do not break progress messages Daniel Kiper
2013-07-19 9:20 ` Atsushi Kumagai
2013-07-16 12:32 ` [PATCH v2 6/7] Mute some compiler warnings Daniel Kiper
2013-07-19 0:03 ` HATAYAMA Daisuke
2013-07-19 9:20 ` Atsushi Kumagai
2013-07-16 12:32 ` [PATCH v2 7/7] Use elf_getshdrstrndx() instead of elf_getshstrndx() Daniel Kiper
2013-07-18 8:03 ` Atsushi Kumagai
2013-07-18 12:52 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373977929-4253-5-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox