Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [v2 0/3] Introduce struct cycle to store cyclic region and clean up
@ 2014-01-23  9:47 Baoquan He
  2014-01-23  9:47 ` [v2 1/3] makedumpfile: introduce struct cycle to store the cyclic region Baoquan He
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Baoquan He @ 2014-01-23  9:47 UTC (permalink / raw)
  To: kexec; +Cc: d.hatayama, kumagai-atsushi, Baoquan He

v1->v2:
    In first_cycle(), start_pfn assignation is not aligned to info->pfn_cyclic.
    Now in v2 change this. Accordingly the pfn in write_elf_header() and
    write_elf_pages_cyclic() need be adjusted to the real beginning of a
    load segment, but not the cycle->start_pfn which may be lower after alignment.


Baoquan He (3):
  makedumpfile: introduce struct cycle to store the cyclic region
  makedumpfile: use struct cycle to update cyclic region and clean up
  makedumpfile: remove member variables representing cyclic pfn region
    in struct DumpInfo

 makedumpfile.c | 497 ++++++++++++++++++++++++++++-----------------------------
 makedumpfile.h |  21 +--
 sadump_info.c  |   4 +-
 3 files changed, 259 insertions(+), 263 deletions(-)

-- 
1.8.3.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [v2 0/3] Introduce struct cycle to store cyclic region and clean up
@ 2014-01-27  1:39 Atsushi Kumagai
  0 siblings, 0 replies; 9+ messages in thread
From: Atsushi Kumagai @ 2014-01-27  1:39 UTC (permalink / raw)
  To: Baoquan He, kexec@lists.infradead.org; +Cc: d.hatayama@jp.fujitsu.com

Hello Baoquan,

On 2014/01/23 18:49:09, kexec <kexec-bounces@lists.infradead.org> wrote:
> v1->v2:
>     In first_cycle(), start_pfn assignation is not aligned to info->pfn_cyclic.
>     Now in v2 change this. Accordingly the pfn in write_elf_header() and
>     write_elf_pages_cyclic() need be adjusted to the real beginning of a
>     load segment, but not the cycle->start_pfn which may be lower after alignment.

Thanks for the self-correction, and I have another comment.

In [v2 2/3], a pfn range check is removed as below:

int
-set_bitmap_cyclic(char *bitmap, unsigned long long pfn, int val)
+set_bitmap_cyclic(char *bitmap, unsigned long long pfn, int val, struct cycle *cycle)
 {
        int byte, bit;

-       if (pfn < info->cyclic_start_pfn || info->cyclic_end_pfn <= pfn)
-               return FALSE;
-

However, "pfn" can be out of the range of cycles in the case of filtering
free pages with free_list, because we have to look up whole free_list every
cycle since free_list isn't sorted.

So this range check should be moved to reset_bitmap_of_free_pages().


Thanks
Atsushi Kumagai

> Baoquan He (3):
>   makedumpfile: introduce struct cycle to store the cyclic region
>   makedumpfile: use struct cycle to update cyclic region and clean up
>   makedumpfile: remove member variables representing cyclic pfn region
>     in struct DumpInfo
>
>  makedumpfile.c | 497 ++++++++++++++++++++++++++++-----------------------------
>  makedumpfile.h |  21 +--
>  sadump_info.c  |   4 +-
>  3 files changed, 259 insertions(+), 263 deletions(-)
>
> --
> 1.8.3.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-02-08  9:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23  9:47 [v2 0/3] Introduce struct cycle to store cyclic region and clean up Baoquan He
2014-01-23  9:47 ` [v2 1/3] makedumpfile: introduce struct cycle to store the cyclic region Baoquan He
2014-01-23  9:47 ` [v2 2/3] makedumpfile: use struct cycle to update cyclic region and clean up Baoquan He
2014-01-27  4:03   ` HATAYAMA Daisuke
2014-01-27  8:55     ` Baoquan He
2014-01-28  7:49       ` Atsushi Kumagai
2014-02-08  9:09         ` Baoquan He
2014-01-23  9:47 ` [v2 3/3] makedumpfile: remove member variables representing cyclic pfn region in struct DumpInfo Baoquan He
  -- strict thread matches above, loose matches on Subject: below --
2014-01-27  1:39 [v2 0/3] Introduce struct cycle to store cyclic region and clean up Atsushi Kumagai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox