From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org, kumagai-atsushi@mxc.nes.nec.co.jp
Cc: Baoquan He <bhe@redhat.com>, vgoyal@redhat.com
Subject: [PATCH 1/7] initialize pfn_memhole in get_num_dumpable_cyclic
Date: Fri, 11 Jul 2014 15:15:58 +0800 [thread overview]
Message-ID: <1405062964-11406-1-git-send-email-bhe@redhat.com> (raw)
This is a code bug. In initialize_2nd_bitmap_cyclic pfn_memhole is
calculated, however it's not initialized before that. If an available
pfn_memhole is wanted after get_num_dumpable_cyclic invocation,
initializing pfn_memhole in get_num_dumpable_cyclic is necessary.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
makedumpfile.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/makedumpfile.c b/makedumpfile.c
index 3884aa5..760bfd1 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -5588,6 +5588,8 @@ get_num_dumpable_cyclic(void)
mdf_pfn_t pfn, num_dumpable=0;
struct cycle cycle = {0};
+ pfn_memhole = info->max_mapnr;
+
for_each_cycle(0, info->max_mapnr, &cycle)
{
if (!exclude_unnecessary_pages_cyclic(&cycle))
--
1.8.4.2
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2014-07-11 7:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 7:15 Baoquan He [this message]
2014-07-11 7:15 ` [PATCH 2/7] functions to get crashkernel memory range Baoquan He
2014-07-11 7:16 ` [PATCH 3/7] preparation functions for parsing vmcoreinfo Baoquan He
2014-07-11 7:16 ` [PATCH 4/7] set vmcoreinfo for kcore Baoquan He
2014-07-11 7:16 ` [PATCH 5/7] prepare the dump loads for kcore analysis Baoquan He
2014-07-23 7:20 ` Atsushi Kumagai
2014-07-23 8:02 ` bhe
2014-07-11 7:16 ` [PATCH 6/7] implement a function to print the memory usage Baoquan He
2014-07-11 7:16 ` [PATCH 7/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-11 7:27 ` [PATCH v2] " Baoquan He
2014-07-23 7:20 ` Atsushi Kumagai
2014-07-23 8:01 ` bhe
2014-07-11 7:35 ` [PATCH 7/7] " Baoquan He
2014-07-11 14:26 ` Vivek Goyal
2014-07-11 14:35 ` Baoquan He
2014-07-11 14:44 ` Vivek Goyal
2014-07-11 14:35 ` Vivek Goyal
2014-07-11 14:39 ` Baoquan He
2014-07-11 14:46 ` Vivek Goyal
2014-07-14 5:22 ` Baoquan He
2014-07-11 14:19 ` [PATCH 1/7] initialize pfn_memhole in get_num_dumpable_cyclic Vivek Goyal
2014-07-11 14:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405062964-11406-1-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox