Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org
Subject: Re: [PATCH 7/7] add a new interface to show the memory usage of 1st kernel
Date: Fri, 11 Jul 2014 10:44:56 -0400	[thread overview]
Message-ID: <20140711144456.GI15611@redhat.com> (raw)
In-Reply-To: <20140711143530.GB5851@dhcp-17-102.nay.redhat.com>

On Fri, Jul 11, 2014 at 10:35:30PM +0800, Baoquan He wrote:

[..]
> > How about calling them just "User process pages" and not "user process
> > data pages" I am assuming that they could contain text too.
> 
> This function is based on the print_report() which is in makedumpfile.
> It has been defined like these already. But I will change this according
> reviewer's comments. After all, they are different.

Actually notation should match what's in makedumpfile man page. So that
a user can easily associate dump filtering levels with pages here.

> 
> > 
> > > pfn_free		0x0000000000133f79	yes		Free pages
> > > pfn_hwpoison		0x0000000000000000	yes		Hwpoison pages
> > > pfn_kernel_data		0x000000000001dd56	no		Dumpable kernel data
> > > 
> > > Total pages on system:	0x00000000001e5f57
> > > Excludable pages:	0x00000000001c8201
> > > Memory Hole: 		0x00000000000386a9
> > 
> > What is "Memory Hole" ?
> 
> That areas which are between "System Ram".

I think we should remove it from output. We are not concerned where memory
holes are. One can look up /proc/iomem to figure out where memory holes
are.

> 
> > 
> > > --------------------------------------------------
> > > Total pages:		0x000000000021e600
> > 
> > How this total pages is different from "Total pages on system"?
> 
> "Total pages on system" is all physical pages without hole. "Total pages"
> is equal to the max_pfn in current system. This is got from the
> print_report() too. It could be removed if people think it's useless.

We are just interested in total pages without memory hole. And can
remove total pages with memory hole.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-07-11 14:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  7:15 [PATCH 1/7] initialize pfn_memhole in get_num_dumpable_cyclic Baoquan He
2014-07-11  7:15 ` [PATCH 2/7] functions to get crashkernel memory range Baoquan He
2014-07-11  7:16 ` [PATCH 3/7] preparation functions for parsing vmcoreinfo Baoquan He
2014-07-11  7:16 ` [PATCH 4/7] set vmcoreinfo for kcore Baoquan He
2014-07-11  7:16 ` [PATCH 5/7] prepare the dump loads for kcore analysis Baoquan He
2014-07-23  7:20   ` Atsushi Kumagai
2014-07-23  8:02     ` bhe
2014-07-11  7:16 ` [PATCH 6/7] implement a function to print the memory usage Baoquan He
2014-07-11  7:16 ` [PATCH 7/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-11  7:27   ` [PATCH v2] " Baoquan He
2014-07-23  7:20     ` Atsushi Kumagai
2014-07-23  8:01       ` bhe
2014-07-11  7:35   ` [PATCH 7/7] " Baoquan He
2014-07-11 14:26   ` Vivek Goyal
2014-07-11 14:35     ` Baoquan He
2014-07-11 14:44       ` Vivek Goyal [this message]
2014-07-11 14:35   ` Vivek Goyal
2014-07-11 14:39     ` Baoquan He
2014-07-11 14:46       ` Vivek Goyal
2014-07-14  5:22         ` Baoquan He
2014-07-11 14:19 ` [PATCH 1/7] initialize pfn_memhole in get_num_dumpable_cyclic Vivek Goyal
2014-07-11 14:28   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140711144456.GI15611@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox