From: Yuri Volchkov <wolchkov.yuri@gmail.com>
To: horms@verge.net.au, kexec@lists.infradead.org
Cc: wolchkov.yuri@gmail.com
Subject: [PATCH] kexec/x86: fix crashkernel reserved mem detection
Date: Thu, 25 Dec 2014 22:38:21 +0900 [thread overview]
Message-ID: <1419514701-9397-1-git-send-email-wolchkov.yuri@gmail.com> (raw)
Function crashkernel_mem_callback had wrong parameters type
So crash_reserved_mem got completely insane values
As a result kexec was unable to allocate segments for crashkernel
For instance, I got this message:
"Could not find a free area of memory of 0x9f000 bytes..."
Signed-off-by: Yuri Volchkov <wolchkov.yuri@gmail.com>
---
kexec/arch/i386/crashdump-x86.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
index 77bdad5..82bf239 100644
--- a/kexec/arch/i386/crashdump-x86.c
+++ b/kexec/arch/i386/crashdump-x86.c
@@ -1041,8 +1041,8 @@ int get_max_crash_kernel_limit(uint64_t *start, uint64_t *end)
static int crashkernel_mem_callback(void *UNUSED(data), int nr,
char *UNUSED(str),
- unsigned long base,
- unsigned long length)
+ unsigned long long base,
+ unsigned long long length)
{
if (nr >= CRASH_RESERVED_MEM_NR)
return 1;
--
2.2.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2014-12-25 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 13:38 Yuri Volchkov [this message]
2015-01-09 6:27 ` [PATCH] kexec/x86: fix crashkernel reserved mem detection Tony Jones
2015-01-09 8:59 ` Baoquan He
2015-01-14 5:31 ` Baoquan He
2015-01-14 6:24 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419514701-9397-1-git-send-email-wolchkov.yuri@gmail.com \
--to=wolchkov.yuri@gmail.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox