Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Tony Jones <tonyj@suse.de>
Cc: wolchkov.yuri@gmail.com, horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec/x86: fix crashkernel reserved mem detection
Date: Fri, 9 Jan 2015 16:59:27 +0800	[thread overview]
Message-ID: <20150109085927.GA8288@dhcp-16-105.nay.redhat.com> (raw)
In-Reply-To: <54AF74B7.4000807@suse.de>

On 01/08/15 at 10:27pm, Tony Jones wrote:
> On 12/25/2014 05:38 AM, Yuri Volchkov wrote:
> > Function crashkernel_mem_callback had wrong parameters type
> > So crash_reserved_mem got completely insane values
> > As a result kexec was unable to allocate segments for crashkernel
> > For instance, I got this message:
> > 	"Could not find a free area of memory of 0x9f000 bytes..."
> > 
> > Signed-off-by: Yuri Volchkov <wolchkov.yuri@gmail.com>
> 
> See the patch attached to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771671
> which also fixes kexec/arch/sh/crashdump-sh.c and kexec/arch/sh/kexec-sh.c
> 
> Definitely a problem.  Without the x86 fix we seem same failure on i586

Hi Tony,

commit 4362bfa make that change, but skip the crashkernel_mem_callback.
It need be fixed.

I am wondering how the insane values happened on i386, and it didn't
happen on x86_64.

Thanks
Baoquan

> 
> tony
> 
> > ---
> >  kexec/arch/i386/crashdump-x86.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
> > index 77bdad5..82bf239 100644
> > --- a/kexec/arch/i386/crashdump-x86.c
> > +++ b/kexec/arch/i386/crashdump-x86.c
> > @@ -1041,8 +1041,8 @@ int get_max_crash_kernel_limit(uint64_t *start, uint64_t *end)
> >  
> >  static int crashkernel_mem_callback(void *UNUSED(data), int nr,
> >                                            char *UNUSED(str),
> > -                                          unsigned long base,
> > -                                          unsigned long length)
> > +                                          unsigned long long base,
> > +                                          unsigned long long length)
> >  {
> >  	if (nr >= CRASH_RESERVED_MEM_NR)
> >  		return 1;
> > 
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-01-09  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25 13:38 [PATCH] kexec/x86: fix crashkernel reserved mem detection Yuri Volchkov
2015-01-09  6:27 ` Tony Jones
2015-01-09  8:59   ` Baoquan He [this message]
2015-01-14  5:31     ` Baoquan He
2015-01-14  6:24 ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150109085927.GA8288@dhcp-16-105.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=tonyj@suse.de \
    --cc=wolchkov.yuri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox