From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-efi@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk,
gregkh@linuxfoundation.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Chun-Yi Lee <jlee@suse.com>,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
matthew.garrett@nebula.com, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH 09/24] kexec_file: Disable at runtime if securelevel has been set
Date: Fri, 07 Apr 2017 08:36:17 -0400 [thread overview]
Message-ID: <1491568577.4184.97.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <27362.1491556638@warthog.procyon.org.uk>
On Fri, 2017-04-07 at 10:17 +0100, David Howells wrote:
> Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
>
> > > Okay, fair enough. I can stick in an OR with an IS_ENABLED on some IMA
> > > symbol. CONFIG_IMA_KEXEC maybe? And also require IMA be enabled?
> >
> > Not quite, since as Dave pointed out, IMA is policy driven. As a
> > policy is installed, we could set a flag.
>
> Does such a flag exist as yet?
Not exactly what is needed. There's a flag named ima_appraise, which
is used internally in IMA. A temporary flag is created, while
validating the rules.
if (default_appraise_rules[i].func == POLICY_CHECK)
temp_ima_appraise |= IMA_APPRAISE_POLICY;
if (!result && (entry->action == UNKNOWN))
result = -EINVAL;
else if (entry->func == MODULE_CHECK)
temp_ima_appraise |= IMA_APPRAISE_MODULES;
else if (entry->func == FIRMWARE_CHECK)
temp_ima_appraise |= IMA_APPRAISE_FIRMWARE;
else if (entry->func == POLICY_CHECK)
temp_ima_appraise |= IMA_APPRAISE_POLICY;
If the entire policy is valid, ima_update_policy_flag() sets the ima_appraise flag.
ima_appraise |= temp_ima_appraise;
From an IMA perspective, either a file hash or signature are valid,
but for this usage it must be a signature. So in addition to testing
entry->func, above, entry->flags would need to be tested as well to
detect if IMA_DIGSIG_REQUIRED is set.
Mimi
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-04-07 12:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk>
2017-04-05 20:15 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
2017-04-07 3:07 ` Dave Young
2017-04-05 20:15 ` [PATCH 08/24] Copy secure_boot flag in boot params across kexec reboot David Howells
2017-04-05 20:15 ` [PATCH 09/24] kexec_file: Disable at runtime if securelevel has been set David Howells
2017-04-07 3:05 ` Dave Young
2017-04-07 3:49 ` Mimi Zohar
2017-04-07 6:19 ` Dave Young
2017-04-07 7:07 ` David Howells
2017-04-07 7:41 ` Dave Young
2017-04-07 8:28 ` Mimi Zohar
2017-04-07 8:42 ` Dave Young
2017-04-07 7:45 ` Mimi Zohar
2017-04-07 8:01 ` Dave Young
2017-04-07 7:09 ` David Howells
2017-04-07 7:46 ` Mimi Zohar
2017-04-07 9:17 ` David Howells
2017-04-07 12:36 ` Mimi Zohar [this message]
2017-04-10 13:19 ` David Howells
2017-05-02 19:01 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491568577.4184.97.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jlee@suse.com \
--cc=kexec@lists.infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox