From: Hoeun Ryu <hoeun.ryu@gmail.com>
To: Dave Young <dyoung@redhat.com>, Russell King <rmk@armlinux.org.uk>
Cc: Matthew Leach <matthew.leach@arm.com>,
Simon Horman <horms@verge.net.au>,
kexec@lists.infradead.org, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH] kexec:arm: support zImage with appended device tree
Date: Tue, 04 Jul 2017 11:09:47 +0900 [thread overview]
Message-ID: <1499134187.1734.42.camel@gmail.com> (raw)
In-Reply-To: <20170704014145.GA8657@dhcp-128-65.nay.redhat.com>
On Tue, 2017-07-04 at 09:41 +0800, Dave Young wrote:
> On 07/03/17 at 05:41pm, Russell King wrote:
> >
> > On Tue, Jun 27, 2017 at 06:51:50PM +0900, Hoeun Ryu wrote:
> > >
> > > >
> > > > What about the initrd? Do you want to append that as well?
> > > I have thought of it.
> > > I think It would be better to have it.
> > > But I think this is the first step to do so.
> > That is something we don't support with the kernel, and would be
> > insane
> > to do so - it would mean that the very dumb decompressor would have
> > to relocate not only the dtb image, but also the initrd image to
> > some other part of memory. It moves the appended dtb image along
> > with
> > the rest of the zImage as one complete blob, but that doesn't work
> > so well for an appended initrd. It will also be rather slow.
> >
> > So I'd like to continue my discouragement of this entire approach
> > and
> > say that kexec-tools should *not* add support for an appended DTB
> > nor
> > an appended initrd.
> I also agree that we'd better not adding this in kexec-tools, --dtb
> works well, the appended dtb does not gain much but it introduces
> more
> code to maintain.
>
I understand and respect your opinion.
Thank you for the review.
> >
> >
> > The kernel build process gives you the kernel image and dtb file.
> > The appended-dtb image support that we have in the kernel is for
> > backwards compatibility with non-DT aware boot loaders that only
> > know how to deal with one or two images at boot time.
> >
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-07-04 2:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 8:55 [PATCH] kexec:arm: support zImage with appended device tree Hoeun Ryu
2017-06-26 2:52 ` Dave Young
2017-06-27 2:13 ` Hoeun Ryu
2017-06-26 9:14 ` Russell King
2017-06-27 2:36 ` Hoeun Ryu
2017-06-27 8:53 ` Russell King
2017-06-27 9:51 ` Hoeun Ryu
2017-07-03 16:41 ` Russell King
2017-07-04 1:41 ` Dave Young
2017-07-04 2:09 ` Hoeun Ryu [this message]
2017-07-04 2:09 ` Hoeun Ryu
2017-06-26 9:15 ` Pratyush Anand
2017-06-27 2:52 ` Hoeun Ryu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499134187.1734.42.camel@gmail.com \
--to=hoeun.ryu@gmail.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=matthew.leach@arm.com \
--cc=rmk@armlinux.org.uk \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox