[PATCH] [makedumpfile] Fix missing last node

[PATCH] [makedumpfile] Fix missing last node

[Bernhard Walle]

This patch fixes a typo which results in duplication of the first node (and the
last node was missing then).

Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 makedumpfile.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -2278,7 +2278,7 @@ get_mm_discontigmem(struct DumpInfo *inf
 			if ((node = next_online_node(node + 1)) < 0) {
 				ERRMSG("Can't get next online node.\n");
 				return FALSE;
-			} else if (!(pgdat = next_online_pgdat(info, node))) {
+			} else if (!(pgdat = next_online_pgdat(info, node + 1))) {
 				ERRMSG("Can't determine pgdat list (node %d).\n",
 				    node);
 				return FALSE;

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] [makedumpfile] Fix missing last node

[Ken'ichi Ohmichi]

Hi Bernhard,

Thank you for your patches and your cooperation.

2007/05/18 12:50:12 +0200, Bernhard Walle <bwalle@suse.de> wrote:
>This patch fixes a typo which results in duplication of the first node (and the
>last node was missing then).

I think the cause of this problem is the other typo.
Does the attached patch fix it ?

Please apply the attached patch with the following makedumpfile:

makedumpfile-1.1.3
 + 2007/05/11 by Ken'ichi, 01-vaddr_to_offset_ia64.patch 
 + 2007/05/11 by Ken'ichi, 02-ia64-discontigmem.patch
 + 2007/05/16 by Bernhard, [Re: Implement memory regions on IA64] patch


Thanks
Ken'ichi Ohmichi

diff -puN makedumpfile.org/makedumpfile.c makedumpfile/makedumpfile.c
--- makedumpfile.org/makedumpfile.c	2007-05-21 20:54:04.000000000 +0900
+++ makedumpfile/makedumpfile.c	2007-05-21 20:54:16.000000000 +0900
@@ -2121,7 +2121,7 @@ pgdat3:
 	if (node == 0)
 		return pgdat;
 
-	for (i = 1; i < node; i++) {
+	for (i = 1; i <= node; i++) {
 		if (!readmem(info, pgdat + OFFSET(pglist_data.pgdat_next),
 		    &pgdat, sizeof pgdat))
 			goto pgdat4;
_

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] [makedumpfile] Fix missing last node

[Bernhard Walle]

* Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> [2007-05-21 09:45]:
> 2007/05/18 12:50:12 +0200, Bernhard Walle <bwalle@suse.de> wrote:
> >This patch fixes a typo which results in duplication of the first node (and the
> >last node was missing then).
> 
> I think the cause of this problem is the other typo.
> Does the attached patch fix it ?

Yes, thanks!


Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec