From: Simon Horman <horms@verge.net.au>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: kexec@lists.infradead.org, Eric Biederman <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kexec: consolidate crash late initialization
Date: Tue, 5 Mar 2013 11:32:06 +0900 [thread overview]
Message-ID: <20130305023206.GL16128@verge.net.au> (raw)
In-Reply-To: <1338372309-24983-1-git-send-email-vdavydov@parallels.com>
On Wed, May 30, 2012 at 02:05:09PM +0400, Vladimir Davydov wrote:
> Use one module_init() instead of two.
I'm not sure I understand the motivation for this change.
> ---
> kernel/kexec.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4e2e472..c3341cb 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1240,7 +1240,6 @@ static int __init crash_notes_memory_init(void)
> }
> return 0;
> }
> -module_init(crash_notes_memory_init)
>
>
> /*
> @@ -1520,7 +1519,13 @@ static int __init crash_save_vmcoreinfo_init(void)
> return 0;
> }
>
> -module_init(crash_save_vmcoreinfo_init)
> +static int __init crash_init(void)
> +{
> + crash_notes_memory_init();
> + crash_save_vmcoreinfo_init();
> + return 0;
> +}
> +module_init(crash_init)
>
> /*
> * Move into place and start executing a preloaded standalone
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2013-03-05 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 10:05 [PATCH] kexec: consolidate crash late initialization Vladimir Davydov
2013-03-05 2:32 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305023206.GL16128@verge.net.au \
--to=horms@verge.net.au \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox