* [PATCH] kexec: consolidate crash late initialization
@ 2012-05-30 10:05 Vladimir Davydov
2013-03-05 2:32 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Davydov @ 2012-05-30 10:05 UTC (permalink / raw)
To: Eric Biederman; +Cc: Vladimir Davydov, kexec, linux-kernel
Use one module_init() instead of two.
---
kernel/kexec.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 4e2e472..c3341cb 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1240,7 +1240,6 @@ static int __init crash_notes_memory_init(void)
}
return 0;
}
-module_init(crash_notes_memory_init)
/*
@@ -1520,7 +1519,13 @@ static int __init crash_save_vmcoreinfo_init(void)
return 0;
}
-module_init(crash_save_vmcoreinfo_init)
+static int __init crash_init(void)
+{
+ crash_notes_memory_init();
+ crash_save_vmcoreinfo_init();
+ return 0;
+}
+module_init(crash_init)
/*
* Move into place and start executing a preloaded standalone
--
1.7.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kexec: consolidate crash late initialization
2012-05-30 10:05 [PATCH] kexec: consolidate crash late initialization Vladimir Davydov
@ 2013-03-05 2:32 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-03-05 2:32 UTC (permalink / raw)
To: Vladimir Davydov; +Cc: kexec, Eric Biederman, linux-kernel
On Wed, May 30, 2012 at 02:05:09PM +0400, Vladimir Davydov wrote:
> Use one module_init() instead of two.
I'm not sure I understand the motivation for this change.
> ---
> kernel/kexec.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4e2e472..c3341cb 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1240,7 +1240,6 @@ static int __init crash_notes_memory_init(void)
> }
> return 0;
> }
> -module_init(crash_notes_memory_init)
>
>
> /*
> @@ -1520,7 +1519,13 @@ static int __init crash_save_vmcoreinfo_init(void)
> return 0;
> }
>
> -module_init(crash_save_vmcoreinfo_init)
> +static int __init crash_init(void)
> +{
> + crash_notes_memory_init();
> + crash_save_vmcoreinfo_init();
> + return 0;
> +}
> +module_init(crash_init)
>
> /*
> * Move into place and start executing a preloaded standalone
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-05 2:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-30 10:05 [PATCH] kexec: consolidate crash late initialization Vladimir Davydov
2013-03-05 2:32 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox