From: Daniel Kiper <daniel.kiper@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: kexec@lists.infradead.org, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 8/9] x86: check kexec relocation code fits in a page
Date: Mon, 16 Sep 2013 14:34:34 +0200 [thread overview]
Message-ID: <20130916123434.GA14630@debian70-amd64.local.net-space.pl> (raw)
In-Reply-To: <1379015347-21653-9-git-send-email-david.vrabel@citrix.com>
On Thu, Sep 12, 2013 at 08:49:06PM +0100, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> The kexec relocation (control) code must fit in a single page so add a
> link time check for this.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> ---
> xen/arch/x86/xen.lds.S | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 9600cdf..078bac6 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -198,3 +198,5 @@ SECTIONS
> .stab.indexstr 0 : { *(.stab.indexstr) }
> .comment 0 : { *(.comment) }
> }
> +
> +ASSERT(__kexec_reloc_size <= PAGE_SIZE, "kexec control code is too large")
ASSERT(kexec_reloc_size - kexec_reloc <= PAGE_SIZE, "kexec control code is too large")
This way you could remove this crazy __kexec_reloc_size variable.
Last time I sent broken solution for that issue. This one works.
Daniel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-09-16 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 19:48 [PATCHv7 0/9] Xen: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-09-12 19:48 ` [PATCH 1/9] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-09-12 19:49 ` [PATCH 2/9] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-09-13 10:26 ` Jan Beulich
2013-09-13 12:37 ` David Vrabel
2013-09-13 14:06 ` Jan Beulich
2013-09-12 19:49 ` [PATCH 3/9] kexec: add infrastructure for handling kexec images David Vrabel
2013-09-12 19:49 ` [PATCH 4/9] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-09-12 19:49 ` [PATCH 5/9] xen: kexec crash image when dom0 crashes David Vrabel
2013-09-12 19:49 ` [PATCH 6/9] libxc: add hypercall buffer arrays David Vrabel
2013-09-12 19:49 ` [PATCH 7/9] libxc: add API for kexec hypercall David Vrabel
2013-09-12 19:49 ` [PATCH 8/9] x86: check kexec relocation code fits in a page David Vrabel
2013-09-16 12:34 ` Daniel Kiper [this message]
2013-09-12 19:49 ` [PATCH 9/9] MAINTAINERS: Add KEXEC maintainer David Vrabel
2013-09-16 12:37 ` Daniel Kiper
2013-09-16 13:41 ` David Vrabel
2013-09-17 1:34 ` Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2013-11-06 14:49 [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-11-06 14:49 ` [PATCH 8/9] x86: check kexec relocation code fits in a page David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916123434.GA14630@debian70-amd64.local.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=kexec@lists.infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox