From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
Keir Fraser <keir@xen.org>,
kexec@lists.infradead.org
Subject: Re: [PATCH 2/9] kexec: add public interface for improved load/unload sub-ops
Date: Fri, 13 Sep 2013 13:37:40 +0100 [thread overview]
Message-ID: <52330714.8010907@citrix.com> (raw)
In-Reply-To: <5233048802000078000F3075@nat28.tlf.novell.com>
On 13/09/13 11:26, Jan Beulich wrote:
>>>> On 12.09.13 at 21:49, David Vrabel <david.vrabel@citrix.com> wrote:
>> +#else /* __XEN_INTERFACE_VERSION__ < 0x00040400 */
>> +
>> +#define KEXEC_CMD_kexec_load KEXEC_CMD_kexec_load_v1
>> +#define KEXEC_CMD_kexec_unload KEXEC_CMD_kexec_unload_v1
>> +typedef struct xen_kexec_load {
>> + int type;
>> + xen_kexec_image_t image;
>> +} xen_kexec_load_t;
>
> Is there anything preventing the use of two #define-s here
> instead of repeating the declaration (which results in these and
> the ones with the _v1 tags not being interchangeable)?
You mean:
#define xen_kexec_load xen_kexec_load_v1
#define xen_kexec_load_t xen_kexec_load_v1_t
I will do that. I'm not sure I understand your concern about them not
being interchangeable though. They do have identical layout.
David
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-09-13 12:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 19:48 [PATCHv7 0/9] Xen: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-09-12 19:48 ` [PATCH 1/9] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-09-12 19:49 ` [PATCH 2/9] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-09-13 10:26 ` Jan Beulich
2013-09-13 12:37 ` David Vrabel [this message]
2013-09-13 14:06 ` Jan Beulich
2013-09-12 19:49 ` [PATCH 3/9] kexec: add infrastructure for handling kexec images David Vrabel
2013-09-12 19:49 ` [PATCH 4/9] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-09-12 19:49 ` [PATCH 5/9] xen: kexec crash image when dom0 crashes David Vrabel
2013-09-12 19:49 ` [PATCH 6/9] libxc: add hypercall buffer arrays David Vrabel
2013-09-12 19:49 ` [PATCH 7/9] libxc: add API for kexec hypercall David Vrabel
2013-09-12 19:49 ` [PATCH 8/9] x86: check kexec relocation code fits in a page David Vrabel
2013-09-16 12:34 ` Daniel Kiper
2013-09-12 19:49 ` [PATCH 9/9] MAINTAINERS: Add KEXEC maintainer David Vrabel
2013-09-16 12:37 ` Daniel Kiper
2013-09-16 13:41 ` David Vrabel
2013-09-17 1:34 ` Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2013-11-06 14:49 [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-11-06 14:49 ` [PATCH 2/9] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-11-07 20:38 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52330714.8010907@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=daniel.kiper@oracle.com \
--cc=keir@xen.org \
--cc=kexec@lists.infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox