From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] build: Use INCLUDES for normal CFLAGS in addition to CFLAGS_ARCH
Date: Tue, 11 Mar 2014 07:57:30 +0100 [thread overview]
Message-ID: <20140311075730.358bc01f@marrow.netinsight.se> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE971F41D3@BPXM01GP.gisp.nec.co.jp>
On Mon, 10 Mar 2014 05:26:34 +0000
Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp> wrote:
> >-CFLAGS = -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> >+CFLAGS = $(INCLUDES) -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE \
> > -DVERSION='"$(VERSION)"' -DRELEASE_DATE='"$(DATE)"'
> > CFLAGS_ARCH = $(INCLUDES) -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> ^^^^^^^^^^^
> CFLAGS_ARCH also doesn't use INCLUDES in the upstream version,
> so this diff and the subject of this patch are wrong.
Sorry about that! I merged in the new version, but apparently we had
some local modifications to the Makefile.
So please drop this patch in the series.
// Simon
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-03-11 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 8:36 [PATCH v2 0/4]: makedumpfile: Makefile improvements Simon Kågström
2014-03-07 8:38 ` [PATCH v2 1/4] build: Derive objects from source files Simon Kågström
2014-03-07 8:38 ` [PATCH v2 2/4] build: Use INCLUDES for normal CFLAGS in addition to CFLAGS_ARCH Simon Kågström
2014-03-10 5:26 ` Atsushi Kumagai
2014-03-11 6:57 ` Simon Kågström [this message]
2014-03-11 9:31 ` Atsushi Kumagai
2014-03-07 8:38 ` [PATCH v2 3/4] build: Honor VPATH to support out-of-tree builds Simon Kågström
2014-03-07 8:38 ` [PATCH v2 4/4] build: Rename generic-sounding SRC -> SRC_BASE Simon Kågström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311075730.358bc01f@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox