From: WANG Chao <chaowang@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH RESEND] condition check fix
Date: Thu, 8 May 2014 22:37:04 +0800 [thread overview]
Message-ID: <20140508143704.GA6852@dhcp12-158.nay.redhat.com> (raw)
In-Reply-To: <20140508141429.GD9224@redhat.com>
On 05/08/14 at 10:14am, Vivek Goyal wrote:
> On Thu, May 08, 2014 at 07:26:17PM +0800, WANG Chao wrote:
> > In commit 91f5b9c ("kdump: pass e820 reserved region to 2nd kernel via
> > e820 table or setup_data"), I made a wrong condition check.
> >
> > We should only add cmdline for a memory range if --pass-memmap-cmdline
> > and the range type isn't RANGE_RESERVED.
> >
> > Signed-off-by: WANG Chao <chaowang@redhat.com>
>
> Ok, this fixes the issue for me. Thanks.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> BTW, on a related note, I see that we are doing GART check two times.
>
> } else if (memcmp(str, "GART\n", 5) == 0) {
> } else if (memcmp(str, "GART\n", 5) == 0) {
>
> I am not sure if it is due to your patches or not.
Right, another stupid carelessness. Already sent a fix.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-05-08 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 11:26 [PATCH RESEND] condition check fix WANG Chao
2014-05-08 14:14 ` Vivek Goyal
2014-05-08 14:37 ` WANG Chao [this message]
2014-05-10 23:43 ` Simon Horman
2014-05-10 23:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508143704.GA6852@dhcp12-158.nay.redhat.com \
--to=chaowang@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox