Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: kexec@lists.infradead.org, WANG Chao <chaowang@redhat.com>
Subject: Re: [PATCH RESEND] condition check fix
Date: Sun, 11 May 2014 08:59:17 +0900	[thread overview]
Message-ID: <20140510235917.GA2595@verge.net.au> (raw)
In-Reply-To: <20140510234354.GG31760@verge.net.au>

On Sun, May 11, 2014 at 08:43:54AM +0900, Simon Horman wrote:
> On Thu, May 08, 2014 at 10:14:29AM -0400, Vivek Goyal wrote:
> > On Thu, May 08, 2014 at 07:26:17PM +0800, WANG Chao wrote:
> > > In commit 91f5b9c ("kdump: pass e820 reserved region to 2nd kernel via
> > > e820 table or setup_data"), I made a wrong condition check.
> > > 
> > > We should only add cmdline for a memory range if --pass-memmap-cmdline
> > > and the range type isn't RANGE_RESERVED.
> > > 
> > > Signed-off-by: WANG Chao <chaowang@redhat.com>
> > 
> > Ok, this fixes the issue for me. Thanks.
> > 
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> 
> Thanks, and apologies for the delay.
> I am currently returning from a weeks vacation.
> I have applied this locally and will push it some
> time after I get off the plane ride home.
> 
> > BTW, on a related note, I see that we are doing GART check two times.
> > 
> >                 } else if (memcmp(str, "GART\n", 5) == 0) {
> >                 } else if (memcmp(str, "GART\n", 5) == 0) {
> > 
> > I am not sure if it is due to your patches or not.
> 
> I believe it is introduced in the same patch that is mentioned above.
> Chao, could you post a fix?

I see you have already done so, thanks.

> 
> > Thanks
> > Vivek
> > 
> > > ---
> > >  kexec/arch/i386/crashdump-x86.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
> > > index cc33347..999a837 100644
> > > --- a/kexec/arch/i386/crashdump-x86.c
> > > +++ b/kexec/arch/i386/crashdump-x86.c
> > > @@ -1000,7 +1000,7 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
> > >  		type = mem_range[i].type;
> > >  		size = end - start + 1;
> > >  		add_memmap(memmap_p, &nr_memmap, start, size, type);
> > > -		if (arch_options.pass_memmap_cmdline || type != RANGE_RESERVED)
> > > +		if (arch_options.pass_memmap_cmdline && type != RANGE_RESERVED)
> > >  			cmdline_add_memmap_acpi(mod_cmdline, start, end);
> > >  	}
> > >  
> > > -- 
> > > 1.9.0
> > 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2014-05-11  8:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 11:26 [PATCH RESEND] condition check fix WANG Chao
2014-05-08 14:14 ` Vivek Goyal
2014-05-08 14:37   ` WANG Chao
2014-05-10 23:43   ` Simon Horman
2014-05-10 23:59     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140510235917.GA2595@verge.net.au \
    --to=horms@verge.net.au \
    --cc=chaowang@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox