From: Vivek Goyal <vgoyal@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: kumagai-atsushi@mxc.nes.nec.co.jp, kexec@lists.infradead.org
Subject: Re: [Patch v3 7/7] add a new interface to show the memory usage of 1st kernel
Date: Tue, 29 Jul 2014 08:43:55 -0400 [thread overview]
Message-ID: <20140729124355.GA27389@redhat.com> (raw)
In-Reply-To: <1406535606-16303-8-git-send-email-bhe@redhat.com>
On Mon, Jul 28, 2014 at 04:20:06PM +0800, Baoquan He wrote:
> Recently people complained that they don't know how to decide how
> much disk size need be reserved for kdump. E.g there are lots of
> machines with different memory size, if the memory usage information
> of current system can be shown, that can help them to make an estimate
> how much storage space need be reserved.
>
> In this patch, a new interface is added into makedumpfile. By the
> help of this, people can know the page number of memory in different
> use. The implementation is analyzing the "System Ram" and "kernel text"
> program segment of /proc/kcore excluding the crashkernel range, then
> calculating the page number of different kind per vmcoreinfo.
>
> The print is like below:
> ->$ ./makedumpfile --mem-usage /proc/kcore
> Excluding unnecessary pages : [100.0 %] |
I think above message is now unnecessary. In fact we are not excluding
any pages.
>
> Page number of memory in different use
> --------------------------------------------------
Above is not required.
> TYPE PAGES EXCLUDABLE DESCRIPTION
We probably should put dashes under these headers
TYPE PAGES EXCLUDABLE DESCRIPTION
==== ===== ========== ===========
> ZERO 0 yes Pages filled with zero
> CACHE 562006 yes Cache pages
> CACHE_PRIVATE 353502 yes Cache pages + private
> USER 225780 yes User process pages
> FREE 2761884 yes Free pages
> KERN_DATA 235873 no Dumpable kernel data
What's "Dumpable kernel data" ? Are we saying they are kernel pages which
can't be filtered?
Why not simply call them "kernel data" or "kernel pages"
>
> Total pages on system: 4139045
How about "Total number of pages".
Otherwise this output looks much better than previous version. Thanks for
the changes.
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-07-29 12:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 8:19 [Patch v3 0/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-28 8:20 ` [Patch v3 1/7] initialize pfn_memhole in get_num_dumpable_cyclic Baoquan He
2014-07-28 8:20 ` [Patch v3 2/7] functions to get crashkernel memory range Baoquan He
2014-08-01 7:32 ` Atsushi Kumagai
2014-08-12 9:25 ` bhe
2014-07-28 8:20 ` [Patch v3 3/7] preparation functions for parsing vmcoreinfo Baoquan He
2014-08-01 7:12 ` Atsushi Kumagai
2014-08-12 9:46 ` bhe
2014-08-12 10:01 ` bhe
2014-08-14 7:37 ` Atsushi Kumagai
2014-08-14 8:15 ` bhe
2014-07-28 8:20 ` [Patch v3 4/7] set vmcoreinfo for kcore Baoquan He
2014-08-01 7:12 ` Atsushi Kumagai
2014-08-12 10:08 ` bhe
2014-07-28 8:20 ` [Patch v3 5/7] prepare the dump loads for kcore analysis Baoquan He
2014-08-01 7:12 ` Atsushi Kumagai
2014-08-12 10:10 ` bhe
2014-07-28 8:20 ` [Patch v3 6/7] implement a function to print the memory usage Baoquan He
2014-07-28 8:20 ` [Patch v3 7/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-29 12:43 ` Vivek Goyal [this message]
2014-07-31 2:32 ` Baoquan He
2014-08-01 7:12 ` Atsushi Kumagai
2014-08-12 10:14 ` bhe
2014-08-21 10:31 ` bhe
2014-08-26 2:28 ` Atsushi Kumagai
2014-08-26 3:22 ` bhe
2014-08-26 6:25 ` Petr Tesarik
2014-08-26 14:12 ` bhe
2014-09-02 6:20 ` Atsushi Kumagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729124355.GA27389@redhat.com \
--to=vgoyal@redhat.com \
--cc=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox