Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Cc: kumagai-atsushi@mxc.nes.nec.co.jp, Baoquan He <bhe@redhat.com>,
	vgoyal@redhat.com
Subject: [Patch v3 1/7] initialize pfn_memhole in get_num_dumpable_cyclic
Date: Mon, 28 Jul 2014 16:20:00 +0800	[thread overview]
Message-ID: <1406535606-16303-2-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1406535606-16303-1-git-send-email-bhe@redhat.com>

This is a code bug. In initialize_2nd_bitmap_cyclic pfn_memhole is
calculated, however it's not initialized before that. If an available
pfn_memhole is wanted after get_num_dumpable_cyclic invocation,
initializing pfn_memhole in get_num_dumpable_cyclic is necessary.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 makedumpfile.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/makedumpfile.c b/makedumpfile.c
index 3884aa5..760bfd1 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -5588,6 +5588,8 @@ get_num_dumpable_cyclic(void)
 	mdf_pfn_t pfn, num_dumpable=0;
 	struct cycle cycle = {0};
 
+	pfn_memhole = info->max_mapnr;
+
 	for_each_cycle(0, info->max_mapnr, &cycle)
 	{
 		if (!exclude_unnecessary_pages_cyclic(&cycle))
-- 
1.8.5.3


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-07-28  8:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28  8:19 [Patch v3 0/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-28  8:20 ` Baoquan He [this message]
2014-07-28  8:20 ` [Patch v3 2/7] functions to get crashkernel memory range Baoquan He
2014-08-01  7:32   ` Atsushi Kumagai
2014-08-12  9:25     ` bhe
2014-07-28  8:20 ` [Patch v3 3/7] preparation functions for parsing vmcoreinfo Baoquan He
2014-08-01  7:12   ` Atsushi Kumagai
2014-08-12  9:46     ` bhe
2014-08-12 10:01       ` bhe
2014-08-14  7:37         ` Atsushi Kumagai
2014-08-14  8:15           ` bhe
2014-07-28  8:20 ` [Patch v3 4/7] set vmcoreinfo for kcore Baoquan He
2014-08-01  7:12   ` Atsushi Kumagai
2014-08-12 10:08     ` bhe
2014-07-28  8:20 ` [Patch v3 5/7] prepare the dump loads for kcore analysis Baoquan He
2014-08-01  7:12   ` Atsushi Kumagai
2014-08-12 10:10     ` bhe
2014-07-28  8:20 ` [Patch v3 6/7] implement a function to print the memory usage Baoquan He
2014-07-28  8:20 ` [Patch v3 7/7] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-07-29 12:43   ` Vivek Goyal
2014-07-31  2:32     ` Baoquan He
2014-08-01  7:12   ` Atsushi Kumagai
2014-08-12 10:14     ` bhe
2014-08-21 10:31     ` bhe
2014-08-26  2:28       ` Atsushi Kumagai
2014-08-26  3:22         ` bhe
2014-08-26  6:25           ` Petr Tesarik
2014-08-26 14:12             ` bhe
2014-09-02  6:20               ` Atsushi Kumagai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406535606-16303-2-git-send-email-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox