From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Cc: horms@verge.net.au
Subject: Re: [PATCH] ppc64: erase unnecessary segment info printing
Date: Mon, 2 Feb 2015 11:31:30 +0800 [thread overview]
Message-ID: <20150202033130.GA5398@dhcp-16-116.nay.redhat.com> (raw)
In-Reply-To: <1414570795-29258-1-git-send-email-bhe@redhat.com>
Hi Simon,
ping.
Could you please have a look at this patch and merge it if you think
it's OK?
Thanks
Baoquan
On 10/29/14 at 04:19pm, Baoquan He wrote:
> In ppc64 loading, it will print the segment information. This is not
> wanted since other Archs don't have this. People even think there's
> something wrong. So erase it to make it be consistent with other Archs.
>
> And if people really want to check these info, they can specify "-d"
> option. They are printed in print_segments() too.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
> index ce10367..4a1540e 100644
> --- a/kexec/arch/ppc64/kexec-elf-ppc64.c
> +++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
> @@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
> dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
> dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
>
> - for (i = 0; i < info->nr_segments; i++)
> - fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
> - info->segment[i].mem, info->segment[i].memsz);
> -
> return 0;
> }
>
> --
> 1.9.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-02-02 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:19 [PATCH] ppc64: erase unnecessary segment info printing Baoquan He
2015-02-02 3:31 ` Baoquan He [this message]
2015-02-09 5:55 ` Simon Horman
2015-02-09 6:03 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202033130.GA5398@dhcp-16-116.nay.redhat.com \
--to=bhe@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox