Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Baoquan He <bhe@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] ppc64: erase unnecessary segment info printing
Date: Mon, 9 Feb 2015 14:55:43 +0900	[thread overview]
Message-ID: <20150209055543.GA29385@verge.net.au> (raw)
In-Reply-To: <1414570795-29258-1-git-send-email-bhe@redhat.com>

On Wed, Oct 29, 2014 at 04:19:55PM +0800, Baoquan He wrote:
> In ppc64 loading, it will print the segment information. This is not
> wanted since other Archs don't have this. People even think there's
> something wrong. So erase it to make it be consistent with other Archs.
> 
> And if people really want to check these info, they can specify "-d"
> option. They are printed in print_segments() too.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>

Thanks, applied.

> ---
>  kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/kexec/arch/ppc64/kexec-elf-ppc64.c b/kexec/arch/ppc64/kexec-elf-ppc64.c
> index ce10367..4a1540e 100644
> --- a/kexec/arch/ppc64/kexec-elf-ppc64.c
> +++ b/kexec/arch/ppc64/kexec-elf-ppc64.c
> @@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,
>  	dbgprintf("opal_base is %llx\n", (unsigned long long) my_opal_base);
>  	dbgprintf("opal_entry is %llx\n", (unsigned long long) my_opal_entry);
>  
> -	for (i = 0; i < info->nr_segments; i++)
> -		fprintf(stderr, "segment[%d].mem:%p memsz:%zu\n", i,
> -			info->segment[i].mem, info->segment[i].memsz);
> -
>  	return 0;
>  }
>  
> -- 
> 1.9.0
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2015-02-09  5:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  8:19 [PATCH] ppc64: erase unnecessary segment info printing Baoquan He
2015-02-02  3:31 ` Baoquan He
2015-02-09  5:55 ` Simon Horman [this message]
2015-02-09  6:03   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209055543.GA29385@verge.net.au \
    --to=horms@verge.net.au \
    --cc=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox