From: Simon Horman <horms@verge.net.au>
To: Pratyush Anand <panand@redhat.com>
Cc: geoff@infradead.org, kexec@lists.infradead.org
Subject: Re: [PATCH] purgatory: Fix memcmp for src address increment
Date: Thu, 23 Apr 2015 13:46:14 +0900 [thread overview]
Message-ID: <20150423044614.GD26500@verge.net.au> (raw)
In-Reply-To: <6cdeaea422f53a62d9c72dfb5848565697e27b08.1429758015.git.panand@redhat.com>
On Thu, Apr 23, 2015 at 08:34:17AM +0530, Pratyush Anand wrote:
> src addresses are not being incremented, so only first byte is compared
> instead of first len bytes.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Acked-by: Geoff Levand <geoff@infradead.org>
Thanks, applied.
> ---
> purgatory/string.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/purgatory/string.c b/purgatory/string.c
> index 4f35613ef751..f06c460b08f8 100644
> --- a/purgatory/string.c
> +++ b/purgatory/string.c
> @@ -46,6 +46,8 @@ int memcmp(void *src1, void *src2, size_t len)
> if (*s1 != *s2) {
> return *s2 - *s1;
> }
> + s1++;
> + s2++;
> }
> return 0;
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2015-04-23 4:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 3:04 [PATCH] purgatory: Fix memcmp for src address increment Pratyush Anand
2015-04-23 4:46 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423044614.GD26500@verge.net.au \
--to=horms@verge.net.au \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox