[PATCH] purgatory: Fix memcmp for src address increment

[PATCH] purgatory: Fix memcmp for src address increment

[Pratyush Anand]

src addresses are not being incremented, so only first byte is compared
instead of first len bytes.

Signed-off-by: Pratyush Anand <panand@redhat.com>
Acked-by: Geoff Levand <geoff@infradead.org>
---
 purgatory/string.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/purgatory/string.c b/purgatory/string.c
index 4f35613ef751..f06c460b08f8 100644
--- a/purgatory/string.c
+++ b/purgatory/string.c
@@ -46,6 +46,8 @@ int memcmp(void *src1, void *src2, size_t len)
 		if (*s1 != *s2) {
 			return *s2 - *s1;
 		}
+		s1++;
+		s2++;
 	}
 	return 0;
 	
-- 
2.1.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] purgatory: Fix memcmp for src address increment

[Simon Horman]

On Thu, Apr 23, 2015 at 08:34:17AM +0530, Pratyush Anand wrote:
> src addresses are not being incremented, so only first byte is compared
> instead of first len bytes.
> 
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Acked-by: Geoff Levand <geoff@infradead.org>

Thanks, applied.

> ---
>  purgatory/string.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/purgatory/string.c b/purgatory/string.c
> index 4f35613ef751..f06c460b08f8 100644
> --- a/purgatory/string.c
> +++ b/purgatory/string.c
> @@ -46,6 +46,8 @@ int memcmp(void *src1, void *src2, size_t len)
>  		if (*s1 != *s2) {
>  			return *s2 - *s1;
>  		}
> +		s1++;
> +		s2++;
>  	}
>  	return 0;
>  	

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec