[PATCH RFC] Drop release date from kexec-tools version output

[PATCH RFC] Drop release date from kexec-tools version output

[Dave Young]

kexec --version reports like below:
kexec-tools 2.0.7 released 05 February 2015

The date string is generated when one run bootstrap script, thus
it is more like a build date instead of release date.
Even for distribution like Fedora it will make more sense if it can
report something like "kexec-tools 2.0.7-1 released 05 February 2015"

In case building from git tree, the date cause more confusion.
So let's remove it from version string unless there is better idea
to resolve the issue.

Signed-off-by: Dave Young <dyoung@redhat.com>
---
 configure.ac  |    3 ---
 kexec/kexec.c |    2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

--- kexec-tools.orig/configure.ac
+++ kexec-tools/configure.ac
@@ -10,9 +10,6 @@ AC_CONFIG_HEADERS([include/config.h])
 AC_LANG(C)
 AC_PROG_CC
 
-AC_DEFINE_UNQUOTED(PACKAGE_DATE, "`date '+%d %B %Y'`",
-		[Define to the release date of this package])
-
 
 dnl -- Compilation platform configuration
 dnl -- the host specifices the host machine for the kexec binary, the
--- kexec-tools.orig/kexec/kexec.c
+++ kexec-tools/kexec/kexec.c
@@ -897,7 +897,7 @@ static int my_load_jump_back_helper(unsi
 
 static void version(void)
 {
-	printf(PACKAGE_STRING " released " PACKAGE_DATE "\n");
+	printf(PACKAGE_STRING "\n");
 }
 
 void usage(void)

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Pratyush Anand]

On 24/08/2015:05:10:05 PM, Dave Young wrote:
> kexec --version reports like below:
> kexec-tools 2.0.7 released 05 February 2015
> 
> The date string is generated when one run bootstrap script, thus
> it is more like a build date instead of release date.
> Even for distribution like Fedora it will make more sense if it can
> report something like "kexec-tools 2.0.7-1 released 05 February 2015"
> 
> In case building from git tree, the date cause more confusion.
> So let's remove it from version string unless there is better idea
> to resolve the issue.

May be we can take same approach what kernel build takes. Kernel build does not
add build/release string. It just add date and time like "Mon Aug 10 23:38:23 UTC 2015".

$ uname -a
Linux dhcppc13 4.1.5-200.fc22.x86_64 #1 SMP Mon Aug 10 23:38:23 UTC 2015 x86_64
x86_64 x86_64 GNU/Linux

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Dave Young]

On 08/24/15 at 03:59pm, Pratyush Anand wrote:
> On 24/08/2015:05:10:05 PM, Dave Young wrote:
> > kexec --version reports like below:
> > kexec-tools 2.0.7 released 05 February 2015
> > 
> > The date string is generated when one run bootstrap script, thus
> > it is more like a build date instead of release date.
> > Even for distribution like Fedora it will make more sense if it can
> > report something like "kexec-tools 2.0.7-1 released 05 February 2015"
> > 
> > In case building from git tree, the date cause more confusion.
> > So let's remove it from version string unless there is better idea
> > to resolve the issue.
> 
> May be we can take same approach what kernel build takes. Kernel build does not
> add build/release string. It just add date and time like "Mon Aug 10 23:38:23 UTC 2015".
> 
> $ uname -a
> Linux dhcppc13 4.1.5-200.fc22.x86_64 #1 SMP Mon Aug 10 23:38:23 UTC 2015 x86_64
> x86_64 x86_64 GNU/Linux
> 

Do you means drop "released" string only and keep the date? I'm also fine with
it, at lease less confusion to me.

Thanks
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Pratyush Anand]

On 25/08/2015:04:47:59 PM, Dave Young wrote:
> On 08/24/15 at 03:59pm, Pratyush Anand wrote:
> > 
> > May be we can take same approach what kernel build takes. Kernel build does not
> > add build/release string. It just add date and time like "Mon Aug 10 23:38:23 UTC 2015".
> > 
> > $ uname -a
> > Linux dhcppc13 4.1.5-200.fc22.x86_64 #1 SMP Mon Aug 10 23:38:23 UTC 2015 x86_64
> > x86_64 x86_64 GNU/Linux
> > 
> 
> Do you means drop "released" string only and keep the date? I'm also fine with
> it, at lease less confusion to me.

Yes, exactly.

Thanks

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Dave Young]

On 08/25/15 at 04:12pm, Pratyush Anand wrote:
> On 25/08/2015:04:47:59 PM, Dave Young wrote:
> > On 08/24/15 at 03:59pm, Pratyush Anand wrote:
> > > 
> > > May be we can take same approach what kernel build takes. Kernel build does not
> > > add build/release string. It just add date and time like "Mon Aug 10 23:38:23 UTC 2015".
> > > 
> > > $ uname -a
> > > Linux dhcppc13 4.1.5-200.fc22.x86_64 #1 SMP Mon Aug 10 23:38:23 UTC 2015 x86_64
> > > x86_64 x86_64 GNU/Linux
> > > 
> > 
> > Do you means drop "released" string only and keep the date? I'm also fine with
> > it, at lease less confusion to me.
> 
> Yes, exactly.
> 

Pratyush, rethink about it, it is still confused. Considering below case:

git clone kexec-tools;
bootstrap and build, the version and date is the current git version and current date
after some time, git pull, upstream bumps to new version
run make again, build/sbin/kexec --version will still show the old date along with new version

I know one can say we should make distclean and run bootstrap again, but it really worth?

Am I the only person with such feel?

Thanks
dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Pratyush Anand]

On 27/08/2015:02:29:57 PM, Dave Young wrote:
> Pratyush, rethink about it, it is still confused. Considering below case:
> 
> git clone kexec-tools;
> bootstrap and build, the version and date is the current git version and current date
> after some time, git pull, upstream bumps to new version
> run make again, build/sbin/kexec --version will still show the old date along with new version

OK, got it..

May be we can take this patch and then it will be good to take Geoff's following patch.

http://git.kernel.org/cgit/linux/kernel/git/geoff/kexec-tools.git/commit/?id=0b18e1d9311e21d2a2f1392607eade138b9aefe7

With this patch we get something like this:
$ ./build/sbin/kexec -v
kexec version: 15.05.14.11.29-g4f6d8ec17529
kexec-tools 2.0.10.git released 27 August 2015

So, we have Date, Time and git shaid as well.

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Simon Horman]

On Thu, Aug 27, 2015 at 01:19:30PM +0530, Pratyush Anand wrote:
> On 27/08/2015:02:29:57 PM, Dave Young wrote:
> > Pratyush, rethink about it, it is still confused. Considering below case:
> > 
> > git clone kexec-tools;
> > bootstrap and build, the version and date is the current git version and current date
> > after some time, git pull, upstream bumps to new version
> > run make again, build/sbin/kexec --version will still show the old date along with new version
> 
> OK, got it..
> 
> May be we can take this patch and then it will be good to take Geoff's following patch.
> 
> http://git.kernel.org/cgit/linux/kernel/git/geoff/kexec-tools.git/commit/?id=0b18e1d9311e21d2a2f1392607eade138b9aefe7
> 
> With this patch we get something like this:
> $ ./build/sbin/kexec -v
> kexec version: 15.05.14.11.29-g4f6d8ec17529
> kexec-tools 2.0.10.git released 27 August 2015
> 
> So, we have Date, Time and git shaid as well.

My feeling is that we should take this patch and get rid of
the sometimes bogus date. Dave, would you care to repost it as a non-RFC?

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH RFC] Drop release date from kexec-tools version output

[Dave Young]

On 09/02/15 at 10:00am, Simon Horman wrote:
> On Thu, Aug 27, 2015 at 01:19:30PM +0530, Pratyush Anand wrote:
> > On 27/08/2015:02:29:57 PM, Dave Young wrote:
> > > Pratyush, rethink about it, it is still confused. Considering below case:
> > > 
> > > git clone kexec-tools;
> > > bootstrap and build, the version and date is the current git version and current date
> > > after some time, git pull, upstream bumps to new version
> > > run make again, build/sbin/kexec --version will still show the old date along with new version
> > 
> > OK, got it..
> > 
> > May be we can take this patch and then it will be good to take Geoff's following patch.
> > 
> > http://git.kernel.org/cgit/linux/kernel/git/geoff/kexec-tools.git/commit/?id=0b18e1d9311e21d2a2f1392607eade138b9aefe7
> > 
> > With this patch we get something like this:
> > $ ./build/sbin/kexec -v
> > kexec version: 15.05.14.11.29-g4f6d8ec17529
> > kexec-tools 2.0.10.git released 27 August 2015
> > 
> > So, we have Date, Time and git shaid as well.
> 
> My feeling is that we should take this patch and get rid of
> the sometimes bogus date. Dave, would you care to repost it as a non-RFC?

Simon, sent, thanks a lot.
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec