From: Petr Tesarik <ptesarik@suse.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>, Toshi Kani <toshi.kani@hp.com>
Subject: Re: [Patch v3] Add persistent memory support
Date: Wed, 23 Sep 2015 10:33:27 +0200 [thread overview]
Message-ID: <20150923103327.37c2f1ec@hananiah.suse.cz> (raw)
In-Reply-To: <20150902010410.GD30886@verge.net.au>
On Wed, 2 Sep 2015 10:04:10 +0900
Simon Horman <horms@verge.net.au> wrote:
> On Tue, Aug 25, 2015 at 03:37:19PM +0800, Dave Young wrote:
>
> [snip]
>
> > Hmm, after looking into old discussion, I found that the options is there for
> > the known issue for calgary iommu. I really doubt there's someone is using it
> > but who knows.
> >
> > calgary code uses saved_max_pfn which is only calculaed when there's memmap=exactmap
> > cmdline params. So before removing the limitation we still need carry the old
> > interface.
> >
> > Hence, I will not object Bao's changes in his patch any more.
>
> Thanks, on the strength of that comment I have applied this patch.
Argh. After adding this patch, kexec-tools no longer builds --with-xen:
gcc -g -O2 -fno-strict-aliasing -Wall -Wstrict-prototypes -I./include -I./util_lib/include -Iinclude/ -I./kexec/arch/x86_64/include -c -MD -o kexec/arch/i386/kexec-x86-common.o kexec/arch/i386/kexec-x86-common.c
kexec/arch/i386/kexec-x86-common.c: In function ‘xen_e820_to_kexec_type’:
kexec/arch/i386/kexec-x86-common.c:158:8: error: ‘E820_PMEM’ undeclared (first use in this function)
case E820_PMEM:
^
kexec/arch/i386/kexec-x86-common.c:158:8: note: each undeclared identifier is reported only once for each function it appears in
kexec/arch/i386/kexec-x86-common.c:160:8: error: ‘E820_PRAM’ undeclared (first use in this function)
case E820_PRAM:
^
Makefile:113: návod pro cíl „kexec/arch/i386/kexec-x86-common.o“ selhal
make: *** [kexec/arch/i386/kexec-x86-common.o] Chyba 1
This happens, because other E820_* macros are defined
in /usr/include/xenctrl.h, but not E820_PMEM and E820_PRAM.
I'm unsure how to fix it.
Petr T
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-09-23 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 9:03 [Patch v3] Add persistent memory support Baoquan He
2015-08-19 9:28 ` Dave Young
2015-08-19 10:45 ` Baoquan He
2015-08-20 2:38 ` Dave Young
2015-08-20 2:52 ` Baoquan He
2015-08-20 7:42 ` Dave Young
2015-08-24 19:54 ` Toshi Kani
2015-08-25 7:37 ` Dave Young
2015-09-02 1:04 ` Simon Horman
2015-09-23 8:33 ` Petr Tesarik [this message]
2015-09-23 9:16 ` Baoquan He
2015-09-23 9:23 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923103327.37c2f1ec@hananiah.suse.cz \
--to=ptesarik@suse.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox