Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: Timur Tabi <timur@codeaurora.org>
Cc: ats-kumagai@wm.jp.nec.com, asamson@codeaurora.org,
	kexec@lists.infradead.org, rruigrok@codeaurora.org,
	sgoel@codeaurora.org, dyoung@redhat.com
Subject: Re: [PATCH 3/4] arm64: Fix KVBASE
Date: Mon, 7 Dec 2015 11:46:53 +0530	[thread overview]
Message-ID: <20151207061653.GC16406@dhcppc13.redhat.com> (raw)
In-Reply-To: <56631206.9040500@codeaurora.org>

Hi Timur,

Thanks for your review.

On 05/12/2015:10:34:14 AM, Timur Tabi wrote:
> Pratyush Anand wrote:
> >+		& (0xffffffffffffffffUL << (VA_BITS - 1));
> 
> Shouldn't this be ULL instead of just UL?

I think on 64 bit platform, unsigned long is always 64 bit (with gcc). More
over, info->page_offset is unsigned long. So, I think using UL would be in sync,
no?

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-12-07  6:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05 16:29 [PATCH 0/4] ARM64: 3 Level page support Pratyush Anand
2015-12-05 16:30 ` [PATCH 1/4] ARM64: Refactor code to support multiple page level Pratyush Anand
2015-12-05 16:30 ` [PATCH 2/4] arm64: Decide VA Bits on the basis of _stext symbol value Pratyush Anand
2015-12-05 16:30 ` [PATCH 3/4] arm64: Fix KVBASE Pratyush Anand
2015-12-05 16:34   ` Timur Tabi
2015-12-07  6:16     ` Pratyush Anand [this message]
2015-12-05 16:30 ` [PATCH 4/4] arm64: Fix for ARM64 3 level translation tables Pratyush Anand
2015-12-10  8:14 ` [PATCH 0/4] ARM64: 3 Level page support Atsushi Kumagai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151207061653.GC16406@dhcppc13.redhat.com \
    --to=panand@redhat.com \
    --cc=asamson@codeaurora.org \
    --cc=ats-kumagai@wm.jp.nec.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=rruigrok@codeaurora.org \
    --cc=sgoel@codeaurora.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox