Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Geoff Levand <geoff@infradead.org>
Cc: "Goel, Sameer" <sgoel@codeaurora.org>,
	timur@codeaurora.org, kexec@lists.infradead.org,
	rruigrok@codeaurora.org, shankerd@codeaurora.org
Subject: Re: [PATCH] arm64:kexec: Memstart should not be before the kernel start address
Date: Tue, 2 Aug 2016 10:25:54 +0900	[thread overview]
Message-ID: <20160802012551.GF7995@linaro.org> (raw)
In-Reply-To: <1470079910.16559.49.camel@infradead.org>

On Mon, Aug 01, 2016 at 12:31:50PM -0700, Geoff Levand wrote:
> Hi,
> 
> On Fri, 2016-07-29 at 16:58 -0600, Goel, Sameer wrote:
> > In our setup we cannot place the kernel starting at 0 address. So, it it 
> > placed at the first valid aligned address after placing the reserved 
> > regions in memory.
> > 
> > The code from the change (https://patchwork.kernel.org/patch/8325221/) 
> > adds the reserved regions to iomem ranges. So, when the kexec tool is 
> > run it picks up the first reserved region as the start address for 
> > physical ram. When the kernel is loaded at this address, it fails to boot.
> > 
> > So, I have put in a filter in the code that would pick up the right 
> > address of the primary kernel after this change was introduced.

You're using Image, not vmlinux, right?
I don't think that it's a good idea to add this sort of restriction
because it is very system-specific.
You'd better use "--mem-min=" parameter in your case.
(In fact, this option doesn't work on the current arm64 port of kexec-tools,
though.)

Thanks,
-Takahiro AKASHI

> > Thanks,
> > Sameer
> 
> 
> Your patch no longer applies.  Please rebase it to my
> for-merge-arm64-v2 branch and re-post.
> 
> -Geoff
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-08-02  1:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 22:14 [PATCH] arm64:kexec: Memstart should not be before the kernel start address Sameer Goel
2016-04-26 23:58 ` Geoff Levand
2016-05-03 15:12   ` Goel, Sameer
2016-06-10 16:41     ` Geoff Levand
2016-07-29 22:58       ` Goel, Sameer
2016-08-01 19:31         ` Geoff Levand
2016-08-02  1:25           ` AKASHI Takahiro [this message]
2016-08-03 23:44             ` Goel, Sameer
2016-08-04  1:16               ` AKASHI Takahiro
2016-08-04 23:15                 ` Goel, Sameer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802012551.GF7995@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=geoff@infradead.org \
    --cc=kexec@lists.infradead.org \
    --cc=rruigrok@codeaurora.org \
    --cc=sgoel@codeaurora.org \
    --cc=shankerd@codeaurora.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox