Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Goel, Sameer" <sgoel@codeaurora.org>
To: Geoff Levand <geoff@infradead.org>, kexec@lists.infradead.org
Cc: timur@codeaurora.org, rruigrok@codeaurora.org, shankerd@codeaurora.org
Subject: Re: [PATCH] arm64:kexec: Memstart should not be before the kernel start address
Date: Fri, 29 Jul 2016 16:58:50 -0600	[thread overview]
Message-ID: <569f36b7-e153-742f-b7fe-c3a1d7b1febc@codeaurora.org> (raw)
In-Reply-To: <1465576876.3105.54.camel@infradead.org>

Hi Geoff,
In our setup we cannot place the kernel starting at 0 address. So, it it 
placed at the first valid aligned address after placing the reserved 
regions in memory.

The code from the change (https://patchwork.kernel.org/patch/8325221/) 
adds the reserved regions to iomem ranges. So, when the kexec tool is 
run it picks up the first reserved region as the start address for 
physical ram. When the kernel is loaded at this address, it fails to boot.

So, I have put in a filter in the code that would pick up the right 
address of the primary kernel after this change was introduced.
Thanks,
Sameer

On 6/10/2016 10:41 AM, Geoff Levand wrote:
> Hi Sameer,
>
>>>> On Tue, 2016-04-26 at 16:14 -0600, Sameer Goel wrote:
>>>>> Starting 4.6-rc4 the kernel memblock start is rounded down to a desirable
>>>>> alignment. So, the kernel can see reserved memory regions before the kernel
>>>>> start address in the iomem query.
>>>>> Need to make sure that the right kernel start address is picked from the iomem
>>>>> query.
>>>>> ---
>
> It is still in question whether or not your's is the correct
> fix.  Could you provide a test case that hits this problem
> so we can work on the solution?
>
> Thanks.
>
> -Geoff
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-07-29 22:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 22:14 [PATCH] arm64:kexec: Memstart should not be before the kernel start address Sameer Goel
2016-04-26 23:58 ` Geoff Levand
2016-05-03 15:12   ` Goel, Sameer
2016-06-10 16:41     ` Geoff Levand
2016-07-29 22:58       ` Goel, Sameer [this message]
2016-08-01 19:31         ` Geoff Levand
2016-08-02  1:25           ` AKASHI Takahiro
2016-08-03 23:44             ` Goel, Sameer
2016-08-04  1:16               ` AKASHI Takahiro
2016-08-04 23:15                 ` Goel, Sameer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569f36b7-e153-742f-b7fe-c3a1d7b1febc@codeaurora.org \
    --to=sgoel@codeaurora.org \
    --cc=geoff@infradead.org \
    --cc=kexec@lists.infradead.org \
    --cc=rruigrok@codeaurora.org \
    --cc=shankerd@codeaurora.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox