From: Simon Horman <horms@verge.net.au>
To: Pratyush Anand <panand@redhat.com>
Cc: Dave Young <dyoung@redhat.com>, kexec@lists.infradead.org
Subject: Re: [PATCH v2 kexec-tools] arm: do not build iomem.o target with no soruce
Date: Mon, 12 Dec 2016 09:04:12 +0100 [thread overview]
Message-ID: <20161212080412.GC10193@verge.net.au> (raw)
In-Reply-To: <9d7b9d56-f4a6-4f0c-533b-20f56296c61a@redhat.com>
On Fri, Dec 09, 2016 at 05:45:55PM +0530, Pratyush Anand wrote:
>
>
> On Friday 09 December 2016 04:30 PM, Simon Horman wrote:
> >Header files should be added to the distribution but not
> >used to derive targets for compilation. In this an attempt was
> >made to build iomem.o, but iomem.c does not exist so this fails.
> >
> >Fixes: 1574ff1aae4f ("arm: include phys_to_virt.h and iomem.h in distribution")
> >Cc: Dave Young <dyoung@redhat.com>
> >Cc: Pratyush Anand <panand@redhat.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> >---
> >v2
> >* add headers directly to dist
> >---
> > kexec/arch/arm/Makefile | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> >diff --git a/kexec/arch/arm/Makefile b/kexec/arch/arm/Makefile
> >index 871979e0ae26..4454f47a48df 100644
> >--- a/kexec/arch/arm/Makefile
> >+++ b/kexec/arch/arm/Makefile
> >@@ -27,9 +27,8 @@ arm_KEXEC_SRCS += $(libfdt_SRCS)
> >
> > arm_UIMAGE = kexec/kexec-uImage.c
> > arm_PHYS_TO_VIRT = kexec/arch/arm/phys_to_virt.c
> >-arm_PHYS_TO_VIRT += kexec/arch/arm/iomem.h
> >-arm_PHYS_TO_VIRT += kexec/arch/arm/phys_to_virt.h
> >
> > dist += kexec/arch/arm/Makefile $(arm_KEXEC_SRCS) $(arm_PHYS_TO_VIRT) \
> >- kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h \
> >+ kexec/arch/arm/iomem.h kexec/arch/arm/phys_to_virt.h \
> >+ kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h \
> > kexec/arch/arm/include/arch/options.h
> >
>
> Reviewed-by: Pratyush Anand <panand@redhat.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-12-12 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 11:00 [PATCH v2 kexec-tools] arm: do not build iomem.o target with no soruce Simon Horman
2016-12-09 12:15 ` Pratyush Anand
2016-12-12 8:04 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212080412.GC10193@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox