From: Daniel Kiper <daniel.kiper@oracle.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: andrew.cooper3@citrix.com, dyoung@redhat.com, horms@verge.net.au,
kexec@lists.infradead.org, konrad.wilk@oracle.com
Subject: Re: [PATCH v2 03/12] crashdump/cris: Add print_crashkernel_region_size() function
Date: Tue, 7 Feb 2017 16:07:49 +0100 [thread overview]
Message-ID: <20170207150749.GD13477@olila.local.net-space.pl> (raw)
In-Reply-To: <1486410144-28595-4-git-send-email-eric.devolder@oracle.com>
On Mon, Feb 06, 2017 at 01:42:15PM -0600, Eric DeVolder wrote:
> From: Daniel Kiper <daniel.kiper@oracle.com>
>
> Provide just print_crashkernel_region_size() stub. This way
> we can properly build kexec utility on cris arch even
> if the functionality is not available on it.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> ---
> kexec/arch/cris/kexec-cris.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kexec/arch/cris/kexec-cris.c b/kexec/arch/cris/kexec-cris.c
> index 4ac2f89..5601d8e 100644
> --- a/kexec/arch/cris/kexec-cris.c
> +++ b/kexec/arch/cris/kexec-cris.c
> @@ -77,6 +77,11 @@ int is_crashkernel_mem_reserved(void)
> return 0;
> }
>
> +void print_crashkernel_region_size(void)
> +{
> + printf("Crashkernel functionality is not available.\n");
Error message is a bit confusing. What about "Crash kernel region size cannot
be printed because this info is not exposed by the system."?
Or simpler: Crash kernel region size is not exposed by the system.
Daniel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-02-07 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 19:42 [PATCH v2 00/12] crashdump: Add print_crashkernel_region_size() function Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 01/12] crashdump/x86: " Eric DeVolder
2017-02-07 14:55 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 02/12] crashdump/arm: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 03/12] crashdump/cris: " Eric DeVolder
2017-02-07 15:07 ` Daniel Kiper [this message]
2017-02-06 19:42 ` [PATCH v2 04/12] crashdump/ia64: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 05/12] crashdump/m68k: " Eric DeVolder
2017-02-07 15:09 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 06/12] crashdump/mips: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 07/12] crashdump/ppc: " Eric DeVolder
2017-02-07 16:06 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 08/12] crashdump/ppc64: " Eric DeVolder
2017-02-06 19:50 ` Konrad Rzeszutek Wilk
2017-02-07 16:09 ` Daniel Kiper
2017-02-06 19:42 ` [PATCH v2 09/12] crashdump/s390: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 10/12] crashdump/sh: " Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 11/12] kexec: Add option to get crash kernel region size Eric DeVolder
2017-02-06 19:42 ` [PATCH v2 12/12] " Eric DeVolder
2017-02-07 16:14 ` Daniel Kiper
2017-02-07 14:42 ` [PATCH v2 00/12] crashdump: Add print_crashkernel_region_size() function Daniel Kiper
2017-02-08 8:37 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207150749.GD13477@olila.local.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dyoung@redhat.com \
--cc=eric.devolder@oracle.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox